Fix ability to compile tests without -DVERIFY. #628

pull gmaxwell wants to merge 1 commits into bitcoin-core:master from gmaxwell:201905-fixtestwithoutverify changing 1 files +15 −5

gmaxwell commented at 9:53 PM on May 25, 2019: contributor

Broken by 3f3964e4.

It's important that the tests are also run without -DVERIFY due to the possibility that side-effects of a VERIFY_CHECK fix a bug that would otherwise be detected.

Use of the verify_check macro in tests isn't sufficient.

Fix ability to compile tests without -DVERIFY.

Broken by 3f3964e4.

It's important that the tests are also run without -DVERIFY due to
 the possibility that side-effects of a VERIFY_CHECK fix a bug that
 would otherwise be detected.

Use of the verify_check macro in tests isn't sufficient.

dcf392027b

real-or-random commented at 8:14 PM on May 26, 2019: contributor

utACK
apoelstra commented at 2:19 PM on May 29, 2019: contributor

ACK
gmaxwell merged this on May 29, 2019
gmaxwell closed this on May 29, 2019
gmaxwell referenced this in commit 1669bb2865 on May 29, 2019
deadalnix referenced this in commit 1b90ab7f06 on Feb 20, 2020
deadalnix referenced this in commit 5d90f61f95 on Feb 21, 2020
sickpig referenced this in commit 9c60edc497 on Mar 24, 2020
sickpig referenced this in commit 787737ffc6 on Mar 24, 2020
ftrader referenced this in commit 4493b2a25f on Apr 16, 2020
sipa cross-referenced this on Jun 9, 2020 from issue Update libsecp256k1 subtree by sipa
fanquake referenced this in commit 8c97780db8 on Jun 13, 2020
sidhujag referenced this in commit 8a3a072968 on Jun 13, 2020
ComputerCraftr referenced this in commit b98f1c6e6c on Jun 16, 2020
UdjinM6 referenced this in commit 9d36ba6570 on Aug 10, 2021
5tefan referenced this in commit 8ded2caa74 on Aug 12, 2021
gades referenced this in commit d855cc511d on May 8, 2022

Contributors

gmaxwell

real-or-random

apoelstra