Avoid calling _is_zero when _set_b32 fails. #629

pull gmaxwell wants to merge 1 commits into bitcoin-core:master from gmaxwell:201905-retryright changing 3 files +4 −4

gmaxwell commented at 10:25 AM on May 26, 2019: contributor

Most of the codebase correctly used short-cutting to avoid calling _is_zero on possibly incompletely initialized elements, but a few places were missed.

Avoid calling secp256k1_*_is_zero when secp256k1_*_set_b32 fails.

Most of the codebase correctly used short-cutting to avoid calling
 _is_zero on possibly incompletely initialized elements, but a few
 places were missed.

cd473e02c3

gmaxwell renamed this:
~~Avoid calling secp256k1_*_is_zero when secp256k1_fe_set_b32 fails.~~
Avoid calling _is_zero when _set_b32 fails.
on May 26, 2019
jonasnick approved
jonasnick commented at 7:42 PM on May 26, 2019: contributor

utACK cd473e02c372217c3a6608ce5afaa543ed78f891
real-or-random commented at 8:08 PM on May 26, 2019: contributor

utACK
apoelstra commented at 2:40 PM on May 29, 2019: contributor

ACK.

Did not check if there are more places that need fixing.
gmaxwell commented at 6:46 PM on May 29, 2019: contributor

re-more places, I checked for them (which is why there is more than one in this PR) but didn't make a heroic effort. I essentially just looked at every _is_zero that wasn't already shortcutted to check if it shouldn't be. If there are places where the test after loading was something else, I might have missed it.
sipa commented at 9:40 PM on May 29, 2019: contributor

utACK cd473e02c372217c3a6608ce5afaa543ed78f891
gmaxwell merged this on May 29, 2019
gmaxwell closed this on May 29, 2019
gmaxwell referenced this in commit e541a90ef6 on May 29, 2019
sipa cross-referenced this on Jun 9, 2020 from issue Update libsecp256k1 subtree by sipa
fanquake referenced this in commit 8c97780db8 on Jun 13, 2020
sidhujag referenced this in commit 8a3a072968 on Jun 13, 2020
ComputerCraftr referenced this in commit b98f1c6e6c on Jun 16, 2020
UdjinM6 referenced this in commit 9d36ba6570 on Aug 10, 2021
5tefan referenced this in commit 8ded2caa74 on Aug 12, 2021
gades referenced this in commit d855cc511d on May 8, 2022

Contributors