travis: Fix argument quoting for ./configure #779

pull real-or-random wants to merge 1 commits into bitcoin-core:master from real-or-random:202007-travis-configure-quoting changing 1 files +2 −5

real-or-random commented at 6:58 AM on July 29, 2020: contributor
When $USE_HOST or $EXTRAFLAGS are empty, we pass (due to quoting) an empty string as a parameter to ./configure, which then believes we want to use a deprecated syntax for specifing a host or a target and yells at us:

configure: WARNING: you should use --build, --host, --target

The fixes are:
- $EXTRAFLAGS could contain multiple flags and should not be quoted at all.
- We can get rid of $USE_HOST by specifying --host="$HOST" directly.

travis: Fix argument quoting for ./configure

When $USE_HOST or $EXTRAFLAGS are empty, we pass (due to quoting) an
empty string as a parameter to ./configure, which then believes we want
to use a deprecated syntax for specifing a host or a target and yells at us:
> configure: WARNING: you should use --build, --host, --target

The fixes are:
 - $EXTRAFLAGS could contain multiple flags and should not be quoted at all.
 - We can get rid of $USE_HOST by specifying --host="$HOST" directly.

9e49a9b255

jonasnick approved
jonasnick commented at 1:03 PM on July 29, 2020: contributor

ACK 9e49a9b2552b7b865ebc43cfd13c9767de65cb4b
jonasnick merged this on Jul 29, 2020
jonasnick closed this on Jul 29, 2020
elichai commented at 3:23 PM on July 29, 2020: contributor

so now it will pass --host=? does autotools handles that correctly?
real-or-random commented at 3:38 PM on July 29, 2020: contributor

so now it will pass --host=? does autotools handles that correctly?

Yep I checked this. You can also pass all of the others empty and it's like it was not passed at all, e.g., --enable-endomormisphm=.

Contributors

real-or-random

jonasnick

elichai