Libcrypto isn't useful here and on some systems UB in OpenSSL's init causes failures.
Fixes #775.
Avoid linking libcrypto in the valgrind ct test. #795
pull gmaxwell wants to merge 1 commits into bitcoin-core:master from gmaxwell:202008_nolibcryptoinct changing 1 files +1 −1-
gmaxwell commented at 10:15 PM on August 10, 2020: contributor
-
57d3a3c64c
Avoid linking libcrypto in the valgrind ct test.
Libcrypto isn't useful here and on some systems UB in OpenSSL's init causes failures. Fixes #775.
-
real-or-random commented at 9:06 AM on August 11, 2020: contributor
ACK 57d3a3c64cf3d435d5d45e323cf9cbe21da8c6cf
-
elichai commented at 9:16 AM on August 11, 2020: contributor
tACK 57d3a3c64cf3d435d5d45e323cf9cbe21da8c6cf
on master:
$ ldd .libs/valgrind_ctime_test linux-vdso.so.1 (0x00007fffd5b4d000) libsecp256k1.so.0 => not found libcrypto.so.1.1 => /usr/lib/libcrypto.so.1.1 (0x00007f0caf8c0000) libc.so.6 => /usr/lib/libc.so.6 (0x00007f0caf6f9000) libdl.so.2 => /usr/lib/libdl.so.2 (0x00007f0caf6f3000) libpthread.so.0 => /usr/lib/libpthread.so.0 (0x00007f0caf6d1000) /lib64/ld-linux-x86-64.so.2 => /usr/lib64/ld-linux-x86-64.so.2 (0x00007f0cafbe5000)with this PR:
$ ldd .libs/valgrind_ctime_test linux-vdso.so.1 (0x00007ffe97cd5000) libsecp256k1.so.0 => not found libgmp.so.10 => /usr/lib/libgmp.so.10 (0x00007f3d888c9000) libc.so.6 => /usr/lib/libc.so.6 (0x00007f3d88702000) /lib64/ld-linux-x86-64.so.2 => /usr/lib64/ld-linux-x86-64.so.2 (0x00007f3d889b1000) - real-or-random approved
- real-or-random merged this on Aug 11, 2020
- real-or-random closed this on Aug 11, 2020
- jasonbcox referenced this in commit 8b8d8b7f29 on Sep 27, 2020
- deadalnix referenced this in commit 862a5e8d40 on Sep 28, 2020
Contributors