Clang 5 emits -Wmissing-field-initializers warnings #855

issue hebasto opened this issue on December 4, 2020

hebasto commented at 2:46 PM on December 4, 2020: member

While compiling the Bitcoin Core master branch (https://github.com/bitcoin/bitcoin/commit/c1604483d34f745fe6dc77a5f1be4fcfad7408a7) with Clang 5 having the following warnings:

src/secp256k1.c:79:9: warning: missing field 'pre_g_128' initializer [-Wmissing-field-initializers]
    { 0 },
        ^
src/secp256k1.c:80:9: warning: missing field 'blind' initializer [-Wmissing-field-initializers]
    { 0 },
        ^
2 warnings generated.

hebasto commented at 3:01 PM on December 4, 2020: member

No warnings with Clang 6.
hebasto commented at 3:03 PM on December 4, 2020: member

Is https://reviews.llvm.org/D28148 a fix?
real-or-random commented at 3:44 PM on December 4, 2020: contributor

Is https://reviews.llvm.org/D28148 a fix?

Probably.

The code is correct and I don't think it's an issue that we have a spurious warning with clang 5. Is there anything you expect us to do about this?
hebasto commented at 7:42 PM on December 4, 2020: member

The code is correct and I don't think it's an issue that we have a spurious warning with clang 5. Is there anything you expect us to do about this?

I thought the issue could affect my work on the build system, as one of CI jobs builds with Clang 5, and -Werror is enabled by default now. But test passed.

Closing.
hebasto closed this on Dec 4, 2020
real-or-random commented at 9:53 AM on December 5, 2020: contributor

Ok, just ping us again if this turns out to be annoying in Core.

This init list has created a bunch of warning in the past, in different variants and different compilers...

Contributors

hebasto

real-or-random