No description provided.
ecdsa adaptor sigs [WIP] #861
pull jesseposner wants to merge 28 commits into bitcoin-core:master from jesseposner:jp/ecdsa-adaptor-sigs changing 9 files +855 −0-
jesseposner commented at 7:48 AM on December 23, 2020: none
-
add ecdsa_adaptor module 90697912f0
-
Move R from adaptor_proof to adaptor_sig and fix args of _adapt ba796036c0
-
Add dleq proof and dleq verify 20ce8325f9
-
Move dleq things in own file and add adaptor sign 05d2374ac7
-
Add ecdsa_adaptor_sig_verify d5000c1473
-
Add ecdsa_adaptor_adapt 15485afe7b
-
add ecdsa_adaptor_extract_secret 279f1d5232
-
cleanup: stricter input validation b8efd902dc
-
Cleanup a few more things 14451dd327
-
Fix adaptor_sig_verify: should compare scalars and not fe's 15c73fc805
-
Clean up docs and reenable tests 12216816d3
-
Make ecdsa_adaptor_sig_verify compare full points instead of only x coords 89f738d63e
-
Add gen2 to dleq challenge and nonce function e7441bd2b5
-
Update TODOs cf08619f31
-
Update docs 39a80653d2
-
Fix dleq tag by removing trailing NUL bytes e58add3ed4
-
Fix not checking return value of dleq_proof in ecdsa_adaptor_sign ebb606e33d
-
Fix dleq tag for challenge hash too 7c37bb478a
-
Fix not checking the return value of secp256k1_ge_set_xo_var 37a34523dd
-
Return 0 in ecdsa_adaptor_extract_secret if the sigs are unrelated 6c47844b64
-
Fix merge 8c0c32f15b
-
Fix merge c5beec2753
-
Revise serialization to match latest spec 3246e15f9c
-
Add spec test vector a8ae2126a4
-
Remove cruft 0e5c845246
-
Fix variable name 1c823825f1
-
Add secp256k1_ecdsa_adaptor_adapt test 9ecedf1c16
-
Add secp256k1_ecdsa_adaptor_extract_secret test 420a946014
-
jonasnick commented at 3:07 PM on December 23, 2020: contributor
This is really cool - thank you for taking it over.
The current consensus is that this library should focus on the demands of Bitcoin Core. Modules outside of that focus can go into the libsecp-zkp fork. I initially wrote this code on top of libsecp, because libsecp-zkp was not up-to-date with the most recent libsecp. But that's not the case anymore and we have mechanisms in place now to bring libsecp-zkp in sync. Therefore, I'd recommend to rebase on top of libsecp-zkp (which should be very straightforward) and open a PR there.
-
jesseposner commented at 5:27 PM on December 23, 2020: none
@jonasnick Thanks for the heads-up! I will re-open the PR in libsecp-zkp.
- jesseposner closed this on Dec 23, 2020
- bitcoin-core deleted a comment on Dec 24, 2020
-
jesseposner commented at 7:54 PM on December 30, 2020: none
Contributors