This function is only used in tests, since its functionality was inlined into secp256k1_ge_set_all_gej_var in #553.
Closes #873.
Remove unused secp256k1_fe_inv_all_var #878
pull sipa wants to merge 1 commits into bitcoin-core:master from sipa:202101_no_set_fe_all_var changing 3 files +1 −83-
sipa commented at 4:18 AM on January 24, 2021: contributor
-
Remove unused secp256k1_fe_inv_all_var 75d2ae149e
- sipa cross-referenced this on Jan 24, 2021 from issue UB in tests: Invalid pointer comparison in secp256k1_fe_inv_all_var by practicalswift
-
gmaxwell commented at 6:24 AM on January 24, 2021: contributor
LGTM.
-
practicalswift commented at 7:49 AM on January 24, 2021: contributor
cr ACK 75d2ae149ef37d3aa42fdefd1529aad89859816c: patch looks correct
-
real-or-random commented at 5:55 PM on January 24, 2021: contributor
utACK https://github.com/bitcoin-core/secp256k1/commit/75d2ae149ef37d3aa42fdefd1529aad89859816c @practicalswift What's a "cr ACK"? ah "code review"?
-
jonasnick commented at 1:39 PM on January 25, 2021: contributor
utACK 75d2ae149ef37d3aa42fdefd1529aad89859816c
- jonasnick merged this on Jan 25, 2021
- jonasnick closed this on Jan 25, 2021
- sipa cross-referenced this on Jan 25, 2021 from issue Safegcd inverses, drop Jacobi symbols, remove libgmp by sipa
- Fabcien referenced this in commit c47149e07c on Apr 8, 2021
- deadalnix referenced this in commit 40fe4ade67 on Apr 9, 2021
