This makes the macro robust against a hypothetical ROUND_TO_ALIGN(foo ? sizeA : size B) invocation.
Add parens around ROUND_TO_ALIGN's parameter. #880
pull roconnor-blockstream wants to merge 1 commits into bitcoin-core:master from roconnor-blockstream:20210125_ROUND_TO_ALIGN changing 1 files +1 −1-
roconnor-blockstream commented at 4:48 PM on January 25, 2021: contributor
-
b6f649889a
Add parens around ROUND_TO_ALIGN's parameter.
This makes the macro robust against a hypothetical ROUND_TO_ALIGN(foo ? sizeA : size B) invocation.
-
jonasnick commented at 4:54 PM on January 25, 2021: contributor
utACK b6f649889ae78573f1959f04172a8e1fe15beab7
-
gmaxwell commented at 5:26 PM on January 25, 2021: contributor
This is how it should be done. LGTM
- real-or-random approved
-
real-or-random commented at 6:06 PM on January 25, 2021: contributor
utACK b6f649889ae78573f1959f04172a8e1fe15beab7
-
sipa commented at 8:04 PM on January 25, 2021: contributor
ACK b6f649889ae78573f1959f04172a8e1fe15beab7. This is the way.
- real-or-random merged this on Jan 26, 2021
- real-or-random closed this on Jan 26, 2021
- roconnor-blockstream deleted the branch on Jan 26, 2021
- Fabcien referenced this in commit 9fe733efd8 on Apr 8, 2021
- deadalnix referenced this in commit bafd6cdfb7 on Apr 9, 2021