Add parens around ROUND_TO_ALIGN's parameter. #880

pull roconnor-blockstream wants to merge 1 commits into bitcoin-core:master from roconnor-blockstream:20210125_ROUND_TO_ALIGN changing 1 files +1 −1
  1. roconnor-blockstream commented at 4:48 PM on January 25, 2021: contributor

    This makes the macro robust against a hypothetical ROUND_TO_ALIGN(foo ? sizeA : size B) invocation.

    See also https://wiki.sei.cmu.edu/confluence/display/c/PRE01-C.+Use+parentheses+within+macros+around+parameter+names.

  2. Add parens around ROUND_TO_ALIGN's parameter.
    This makes the macro robust against a hypothetical ROUND_TO_ALIGN(foo ? sizeA : size B) invocation.
    b6f649889a
  3. jonasnick commented at 4:54 PM on January 25, 2021: contributor

    utACK b6f649889ae78573f1959f04172a8e1fe15beab7

  4. gmaxwell commented at 5:26 PM on January 25, 2021: contributor

    This is how it should be done. LGTM

  5. real-or-random approved
  6. real-or-random commented at 6:06 PM on January 25, 2021: contributor

    utACK b6f649889ae78573f1959f04172a8e1fe15beab7

  7. sipa commented at 8:04 PM on January 25, 2021: contributor

    ACK b6f649889ae78573f1959f04172a8e1fe15beab7. This is the way.

  8. real-or-random merged this on Jan 26, 2021
  9. real-or-random closed this on Jan 26, 2021

  10. roconnor-blockstream deleted the branch on Jan 26, 2021
  11. Fabcien referenced this in commit 9fe733efd8 on Apr 8, 2021
  12. deadalnix referenced this in commit bafd6cdfb7 on Apr 9, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 18:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me