build: Add workaround for automake 1.13 and older #891

pull real-or-random wants to merge 1 commits into bitcoin-core:master from real-or-random:202101-legacy-autoconf changing 1 files +8 −0

real-or-random commented at 10:06 PM on February 1, 2021: contributor

Fixes #890.
build: Add workaround for automake 1.13 and older
Fixes #890.
f329bba244
real-or-random commented at 10:29 AM on February 15, 2021: contributor
I used a Docker image to verify that this solves the problem on CentOS7.

If anyone wants to check:

Run docker run -it --rm centos:7 and then
```
yum -y install automake git libtool

cd
git clone https://github.com/bitcoin-core/secp256k1 
cd secp256k1

./autogen.sh

git fetch origin pull/891/head
git checkout FETCH_HEAD
./autogen.sh
...
```
To clean up, docker rmi centos:7.
hebasto commented at 7:38 PM on February 17, 2021: member

A bit related note: https://github.com/bitcoin/bitcoin/pull/18290
jonasnick commented at 12:40 PM on February 26, 2021: contributor

Can report that this doesn't break my setup at least (automake 1.16).
michaelfolkson commented at 11:22 AM on February 27, 2021: member

This PR builds fine on MacOS Big Sur, automake 1.16.3. Will need to move to my Linux machine to test automake versions 1.13 and older. brew doesn't seem to easily support installing old versions.
real-or-random commented at 1:44 PM on February 27, 2021: contributor
I think this is ready to merge with
- 4 reports that this does not break anything for automake > 1.13. (including #890 (comment))
- 2 reports that this solves a problem for automake <= 1.13 (again including the one in the linked issue)
But maybe someone could leave at least one ACK. :)
michaelfolkson commented at 12:29 PM on February 28, 2021: member

Reviewed the small code change and doesn't break my setup. I have no reason not to ACK this :)

ACK f329bba244264fb5f2c952c11e614987519d0dbc
real-or-random merged this on Mar 2, 2021
real-or-random closed this on Mar 2, 2021
Fabcien referenced this in commit 505f86869b on Apr 8, 2021
deadalnix referenced this in commit 13f5ffe657 on Apr 9, 2021

Contributors

Linked (view graph)

#890 autogen failed on centos7(AC_PROG_CC cannot be called after AM_PROG_CC_C_O)