Extra validation and comments on top of: Rewrite mul/sqr for 32bit/64bit #91

pull sipa wants to merge 3 commits into bitcoin-core:master from sipa:opt-mul-sqr changing 2 files +770 −334

sipa commented at 5:53 PM on November 3, 2014: contributor

Builds further on #73.

Rewrite mul/sqr for 32bit/64bit

- interleave calculation of the lower and upper partial product ranges, and reduction
- less registers needed, more opportunities for parallel ops
- "bench" performance: +3.5% for 64bit, +7.5% for 32bit (as tested on a 64-bit machine)

5fcd6dd39c

Add range checks in secp256k1_fe_mul_inner a746cc55a6
Annotate inner_{mul,sqr} with relations between inputs and outputs. 0220d2cfb9
sipa commented at 5:54 PM on November 3, 2014: contributor

Resubmitting because Travis apparently missed the previous one.
sipa commented at 6:51 AM on November 4, 2014: contributor

Closing as it's based on outdated code.
sipa closed this on Nov 4, 2014

Contributors

sipa

Linked (view graph)

#73 Rewrite mul/sqr for 32bit/64bit