This removes the need for a separate native toolchain to build gen_context, and the issues around compilation options affecting one but not the other.
Alternative to #918.
Replace gen_context.c with a Python implementation #919
pull sipa wants to merge 2 commits into bitcoin-core:master from sipa:202104_python_precomp changing 7 files +229 −200-
sipa commented at 1:18 AM on April 13, 2021: contributor
- sipa force-pushed on Apr 13, 2021
-
Replace gen_context.c with gen_context.py 4c3f35b375
-
Test ecmult_gen with all 2^i+2^j 7c3d27a910
- sipa force-pushed on Apr 13, 2021
-
- real-or-random cross-referenced this on Apr 19, 2021 from issue mingw builds by real-or-random
-
apoelstra commented at 5:53 PM on June 10, 2021: contributor
concept ACK. I think this would work well for rust-bitcoin.
-
fanquake commented at 1:44 AM on June 29, 2021: member
Concept ACK - ran into issues running gen_context when cross-compiling with mingw-w64 while having Wine installed.
-
real-or-random commented at 8:02 AM on June 29, 2021: contributor
As an alternative, @roconnor-blockstream is working on extending gen_context in #956. The plan (in that PR or in a follow up PR) is to simply ship with precomputed headers then, which would removes the need for running gen_context (or python) entirely for all supported builds.
-
real-or-random commented at 1:45 PM on November 19, 2021: contributor
Closing in favor of #988 .
- real-or-random closed this on Nov 19, 2021
- real-or-random cross-referenced this on Apr 19, 2023 from issue autotools: `make precomp` does not work for out-of-source builds by hebasto
- real-or-random cross-referenced this on Apr 19, 2023 from issue build: Move generation of prebuilt files out of build system by real-or-random
Contributors
Linked (view graph)
#918 Clean up configuration in gen_context #920 Test all ecmult functions with many j*2^i combinations#923 mingw builds#956 Replace ecmult_context with a generated static array.#988 Make signing table fully static#1280 autotools: `make precomp` does not work for out-of-source builds#1281 build: Move generation of prebuilt files out of build system