These VPATH builds are supported natively by autotools, so we can just rely on them.
This also removes the leftover obj directory and provides an empty build
directory instead.
Recommend VPATH (out-of-tree) builds in README #939
pull real-or-random wants to merge 3 commits into bitcoin-core:master from real-or-random:202105-vpath-builds changing 4 files +16 −6-
real-or-random commented at 3:09 PM on May 6, 2021: contributor
-
236b5bb66f
readme: Recommend VPATH (out-of-tree) builds
These VPATH builds are supported natively by autotools, so we can just rely on them. This also removes the leftover `obj` directory.
-
ci: Enable out-of-tree builds 37f473436e
-
readme: Improve instructions for coverage reports 26afece736
- real-or-random force-pushed on May 6, 2021
-
gmaxwell commented at 4:57 AM on May 9, 2021: contributor
What advantage does this gain? For coverage it seems fine to me, but 99.9% of users won't read the build instructions, and will just type ./configure && make like almost all other packages. Maybe then they'll open PRs adding obj to .gitignore, but in any case they'll be using something different from what gets tested.
For coverage, that's weird enough that RTFM is expected and even if people don't do whats expected it would impact far fewer people.
-
real-or-random commented at 3:41 PM on May 9, 2021: contributor
I think it's always a good idea to keep the tree as clean as possible. But that's my personal preference and yeah I agree, I guess we shouldn't recommend it to users if it's too uncommon and makes testing more complicated.
Maybe then they'll open PRs adding obj to .gitignore, but in any case they'll be using something different from what gets tested.
Not sure what you're referring to. If I'm not mistaken, the
objdirectory is currently unused, we should remove it in any case. -
gmaxwell commented at 8:22 PM on May 9, 2021: contributor
Ah, the project uses subdir-objects so indeed obj is unused. Sorry, I was confused by the fact that this PR removed it, as I assumed they it did so because they'd end up under the build directory. :)
-
real-or-random commented at 9:51 AM on May 12, 2021: contributor
Closing in favor of #941.
- real-or-random closed this on May 12, 2021
- real-or-random cross-referenced this on May 14, 2021 from issue Clean up git tree by real-or-random
Contributors
Linked (view graph)