Misc. Warning and cosmetic error cleanups. #95

pull gmaxwell wants to merge 2 commits into bitcoin-core:master from gmaxwell:warnings1 changing 2 files +13 −15

gmaxwell commented at 9:18 PM on November 4, 2014: contributor

This fixes a cosmetic precedence bug in the tests along with some type warnings.

It also adds a dummy cast to the CHECK macro to avoid hundreds of statement with no effect warnings on compilers that warn about such things.

Misc. Warning and cosmetic error cleanups.

This fixes a cosmetic precedence bug in the tests along with some
 type warnings.

It also adds a dummy cast to the CHECK macro to avoid hundreds
 of statement with no effect warnings on compilers that warn about
 such things.

9974d8693e

gmaxwell commented at 9:20 PM on November 4, 2014: contributor

It appears that VERIFY_CHECK is only used with a side effect once in the codebase. I somewhat question the wisdom of using a side-effect preserving macro elsewhere... simply because it'll be a bunch of dead code for the compiler to eliminate (which non-optimizing compilers won't).

Perhaps we could split VERIFY_CHECK into a side effect preserving and one not?
Remove some dead variables in the tests. 79ad6d44ea
sipa merged this on Nov 5, 2014
sipa closed this on Nov 5, 2014
sipa referenced this in commit ef6f677679 on Nov 5, 2014

Contributors

gmaxwell