This function isn't used outside of this module so it should be declared static
`secp256k1_schnorrsig_sign_internal` should be static #976
pull elichai wants to merge 1 commits into bitcoin-core:master from elichai:missing-static changing 1 files +1 −1-
elichai commented at 9:52 AM on September 15, 2021: contributor
-
Add missing static to secp256k1_schnorrsig_sign_internal 72713872a8
- real-or-random approved
-
real-or-random commented at 10:30 AM on September 15, 2021: contributor
ACK 72713872a8597884918bcf1edbc12f5c969ca680
-
jonasnick commented at 11:59 AM on September 15, 2021: contributor
ACK 72713872a8597884918bcf1edbc12f5c969ca680
-
sipa commented at 12:18 PM on September 15, 2021: contributor
ACK
- real-or-random merged this on Sep 15, 2021
- real-or-random closed this on Sep 15, 2021
- elichai deleted the branch on Sep 15, 2021
- jonasnick cross-referenced this on Sep 15, 2021 from issue Upstream PRs 969, 956, 783, 976 by jonasnick
- fanquake referenced this in commit ff458a7b78 on Sep 29, 2021
- real-or-random referenced this in commit 7812feb896 on Oct 15, 2021
- fanquake referenced this in commit 8f5cd5e893 on Oct 20, 2021
- sipa referenced this in commit f727914d7e on Oct 28, 2021
- sipa referenced this in commit 440f7ec80e on Oct 31, 2021
- dhruv referenced this in commit 395e1155b9 on Nov 2, 2021
- dhruv referenced this in commit 184e1fac17 on Nov 2, 2021
- sipa referenced this in commit d057eae556 on Dec 2, 2021
- fanquake referenced this in commit c4a1e09a8c on Dec 3, 2021
- sipa referenced this in commit 86dbc4d075 on Dec 15, 2021
- gwillen referenced this in commit 35d6112a72 on May 25, 2022
- janus referenced this in commit 879a9a27b9 on Jul 10, 2022
- patricklodder referenced this in commit 21badcf9d2 on Jul 25, 2022
- patricklodder referenced this in commit 03002a9013 on Jul 28, 2022
- backpacker69 referenced this in commit 77186f4a04 on Jan 18, 2023
- str4d referenced this in commit 6de4698bf9 on Apr 21, 2023
- vmta referenced this in commit e1120c94a1 on Jun 4, 2023
- vmta referenced this in commit 8f03457eed on Jul 1, 2023
Contributors