No description provided.
Branch-free point addition #98
pull sipa wants to merge 2 commits into bitcoin-core:master from sipa:constadd changing 4 files +229 −5-
sipa commented at 7:06 PM on November 11, 2014: contributor
- sipa force-pushed on Nov 11, 2014
- sipa renamed this:
Constant-time point addition
Branch-free point addition
on Nov 11, 2014 -
gmaxwell commented at 9:51 PM on November 11, 2014: contributor
ACK. See nit.
-
Branch-free point addition 9338dbf791
- sipa force-pushed on Nov 11, 2014
-
sipa commented at 10:35 PM on November 11, 2014: contributor
Unnitted.
-
peterdettman commented at 3:37 AM on November 12, 2014: contributor
Looks good. Perhaps an _fe_negate can be saved in _gej_add_ge; I'll put a snippet together.
If there's a future possibility of a _gej_add_gej it might be worth flagging that r->x/y are written to before reads from b->x/y, to avoid a possibly silent bug injection down the road.
-
peterdettman commented at 5:01 AM on November 12, 2014: contributor
https://github.com/peterdettman/secp256k1/commit/3dc6ce38dff28458ffdc13b51e8ac54bf7cdc05d shows a rearrangement to save an _fe_negate.
-
gmaxwell commented at 6:10 AM on November 12, 2014: contributor
Yes, _gej_add_gej would be useful for e.g. ECDH, and also tests.
-
Rearrange _gej_add_ge to save an _fe_negate fb1bb0b445
-
sipa commented at 10:17 AM on November 12, 2014: contributor
Cherry-picked.
- sipa merged this on Nov 12, 2014
- sipa closed this on Nov 12, 2014
- sipa referenced this in commit 7ff4770e15 on Nov 12, 2014
Contributors