tests: remove `secp256k1_fe_verify` from tests.c and modify `_fe_from_storage` to call `_fe_verify` #986

pull siv2r wants to merge 1 commits into bitcoin-core:master from siv2r:fe-verify-bug changing 3 files +2 −4

siv2r commented at 10:47 AM on October 2, 2021: contributor
Changes: (Suggested in secp256k1 IRC channel)
- secp256k1_fe_verify is removed from tests since it throws an error if the build does not define VERIFY. (Ex: ./configure --enable-coverage does not define VERIFY)
- secp256k1_fe_from_storage calls secp256k1_fe_verify in the VERIFY build to check for invalid field element.
To test the changes build secp256k1 with ./configure --enable-coverage and run
```
make
make check
```
You can find my make check output here.

tests: remove `secp256k1_fe_verify` from tests.c and modify `secp256k1_fe_from_storage` to call `secp256k1_fe_verify`

1. secp256k1_fe_verify is removed from tests since, it throws an error if VERIFY is not defined during compilation.
   (Ex: ./configure --enable-coverage)
2. `secp256k1_fe_from_storage` calls `secp256k1_fe_verify` in the VERIFY build to check for invalid field element.

d43993724d

real-or-random approved
real-or-random commented at 1:44 PM on October 3, 2021: contributor

utACK d43993724deb5fdc1d2162f7423f8e8398103dd5 diff looks correct, I didn't run the tests locally

Thanks!
roconnor-blockstream commented at 1:26 PM on October 4, 2021: contributor

utACK d439937 diff looks correct, I also didn't run the tests locally.
jonasnick commented at 6:52 PM on October 4, 2021: contributor

ACK d43993724deb5fdc1d2162f7423f8e8398103dd5 ran tests with --enable-coverage

Thanks @siv2r
jonasnick merged this on Oct 4, 2021
jonasnick closed this on Oct 4, 2021
siv2r commented at 7:05 PM on October 4, 2021: contributor

Thanks for the review :)
siv2r deleted the branch on Oct 4, 2021
fanquake referenced this in commit 8f5cd5e893 on Oct 20, 2021
sipa referenced this in commit f727914d7e on Oct 28, 2021
sipa referenced this in commit 440f7ec80e on Oct 31, 2021
sipa referenced this in commit d057eae556 on Dec 2, 2021
fanquake referenced this in commit c4a1e09a8c on Dec 3, 2021
sipa referenced this in commit 86dbc4d075 on Dec 15, 2021
jonasnick cross-referenced this on Jan 2, 2022 from issue Sync Upstream by jonasnick
real-or-random referenced this in commit 21e2d65b79 on Jan 5, 2022
gwillen referenced this in commit 35d6112a72 on May 25, 2022
janus referenced this in commit 879a9a27b9 on Jul 10, 2022
patricklodder referenced this in commit 21badcf9d2 on Jul 25, 2022
patricklodder referenced this in commit 03002a9013 on Jul 28, 2022
backpacker69 referenced this in commit 77186f4a04 on Jan 18, 2023
str4d referenced this in commit 6de4698bf9 on Apr 21, 2023
vmta referenced this in commit e1120c94a1 on Jun 4, 2023
vmta referenced this in commit 8f03457eed on Jul 1, 2023

Contributors