.gitignore: add build-aux/ltmain.sh-e #998

pull Sjors wants to merge 1 commits into bitcoin-core:master from Sjors:2021/10/ignore changing 1 files +1 −0
  1. Sjors commented at 1:34 PM on October 21, 2021: member

    When running autogen in LibWally, which uses secp256k1-zkp as a submodule, this file is left on my system. It also happens when I swap out secp256k1-zkp for secp256k1.

    It does not happen when I compile secp256k1 directly, so perhaps this is an issue on the LibWally side.

  2. .gitignore: add build-aux/ltmain.sh-e b03804b03b
  3. Sjors commented at 1:35 PM on October 21, 2021: member
  4. real-or-random commented at 1:42 PM on October 21, 2021: contributor

    I think what's happening here is that some sed variant is misinterpreting the command line arguments.

    https://github.com/ElementsProject/libwally-core/blob/master/tools/autogen.sh#L7 reads:

    sed -i -e "s/\$AR $a /ar $a /" $f
    

    Now my GNU sed has in the man page:

           -i[SUFFIX], --in-place[=SUFFIX]
    
                  edit files in place (makes backup if SUFFIX supplied)
    

    So I believe the -i -e is somehow wrongly parsed as --in-place='-e', or "edit $f (=ltmain.sh) in place but create a backup file with suffix '-e'". Oo

  5. Sjors commented at 1:51 PM on October 21, 2021: member

    Sed on macOS is famous for misinterpreting. Think Different, was Apple's motto. Maybe the script should call gsed instead, which is already a requirement IIUC: https://github.com/ElementsProject/libwally-core/blob/master/configure.ac#L95-L104

  6. Sjors closed this on Oct 21, 2021

  7. Sjors referenced this in commit 9241d2cfb4 on Oct 21, 2021
  8. Sjors cross-referenced this on Oct 21, 2021 from issue autogen: use gsed in macOS workaround by Sjors
  9. Sjors deleted the branch on Oct 21, 2021
  10. jgriffiths referenced this in commit f4cdc72988 on Oct 21, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin-core/secp256k1. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-15 03:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me