BIP 341: allow taproot_sign_key with no script tree #1350

1. 
   jonasnick commented at 8:33 am on August 12, 2022: contributor

   In contrast to taproot_output_script, taproot_sign_key was not able to deal with a script_tree that is None. This commit fixes taproot_sign_key such that it can sign for such outputs.

   This commit avoids changing the behavior of the functions except taproot_sign_key at the cost of having some code duplication. Alternatively, one could let taproot_tree_helper deal with a None script_tree directly.

   CC @sipa @ajtowns

2. jonasnick cross-referenced this on Aug 12, 2022 from issue Update bip-0341.mediawiki by Randy808
3. 
   Randy808 commented at 10:09 am on August 12, 2022: none

   Yeah this addresses the issue brought up in #1348 👍
4. luke-jr added the label Proposed BIP modification on Sep 29, 2022
5. 
   sipa commented at 6:16 pm on November 10, 2022: member

   ACK 3b6b398e7723e501939fac993d6ca5ca72f89975
6. manda2020panda approved
7. 
   kallewoof commented at 2:17 am on January 4, 2023: member

   Conflicts.
8. BIP 341: allow taproot_sign_key with no script tree

   In contrast to taproot_output_script, taproot_sign_key was not able to deal with
   a script_tree that is None. This commit fixes taproot_sign_key such that it can
   sign for such outputs.
   
   This commit avoids changing the behavior of the functions except
   taproot_sign_key at the cost of having some code duplication. Alternatively, one
   could let taproot_tree_helper deal with a None script_tree directly.

   3d243d8a49
9. jonasnick force-pushed on Jan 4, 2023
10. 
    jonasnick commented at 2:32 pm on January 4, 2023: contributor

    rebased
11. kallewoof merged this on Jan 4, 2023
12. kallewoof closed this on Jan 4, 2023

    ---

Contributors
jonasnick Randy808 sipa manda2020panda kallewoof

Labels
Proposed BIP modification