Mark Taproot BIPs as Final #1423
pull uncomputable wants to merge 2 commits into bitcoin:master from uncomputable:taproot-final changing 5 files +8 −8-
uncomputable commented at 3:21 pm on February 19, 2023: contributorTaproot is supported by Bitcoin Core and adopted by a majority of the network, so it should be marked as Final. The progression from Draft to Proposed and from Proposed to Final was likely forgotten.
-
Mark Taproot BIPs as Final 43fa7cf13d
-
Fkhaibari approved
-
bitcoin deleted a comment on Feb 19, 2023
-
real-or-random approved
-
real-or-random commented at 6:19 pm on February 19, 2023: contributorACK 43fa7cf13d3ed35bcd2dd518c2fa0f41a4d2caa7
-
jonasnick commented at 7:34 pm on February 19, 2023: contributorACK 43fa7cf13d3ed35bcd2dd518c2fa0f41a4d2caa7
-
augustoproiete commented at 3:01 am on February 20, 2023: noneACK
43fa7cf
-
kallewoof commented at 1:44 am on February 21, 2023: memberI interpret ‘final’ as something that is adopted and in use, as opposed to a proposal, which is not yet (widely non-experimentally) used. So I think fixes post-final state are fine.
-
luke-jr commented at 5:15 pm on February 21, 2023: memberYou forgot BIP 343, which was used to activate Taproot.
-
Mark BIP 343 as Final f4a05c1ced
-
uncomputable commented at 9:09 pm on February 21, 2023: contributorThanks for pointing this out. I added a new commit. Not everyone seems to want to finalize BIP 343, so we can merge with or without it.
-
jonasnick commented at 9:49 pm on February 21, 2023: contributor
-
michaelfolkson commented at 10:15 pm on February 21, 2023: contributor
Personally I’m not bothered. I agree BIP 340-342 should be made Final. BIP 343 should also be made Final. Activation mechanism(s) seem to me to be entirely independent to the proposal(s) they are activating. I looked up SegWit activation BIPs and they were made Final in an independent pull request (#571) to the SegWit BIPs.
So happy to open an independent pull request to this one to make BIP 343 Final if that is what is blocking this.
-
michaelfolkson cross-referenced this on Feb 21, 2023 from issue Mark BIP343 as Final by michaelfolkson
-
michaelfolkson commented at 11:37 pm on February 21, 2023: contributor
ACK f4a05c1ced66f9f6a10fb1d741648dbe5be10301
Or alternatively remove the BIP 343 commit and merge #1426 instead. Either is fine with me.
-
tcooksey1972 approved
-
uncomputable commented at 2:13 pm on February 26, 2023: contributorAny opinions? Otherwise, let’s merge it with BIP 343 included. We can squash the two commits to finalize all three BIPs at the same time, if that is an issue.
-
kallewoof merged this on Feb 26, 2023
-
kallewoof closed this on Feb 26, 2023
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 03:10 UTC
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 03:10 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me