Add BIP39 Elixir implementation (mnemo) #883
pull aerosol wants to merge 1 commits into bitcoin:master from aerosol:add-bip39-implementation changing 1 files +1 −0-
aerosol commented at 1:27 am on January 26, 2020: contributorThis PR adds another Elixir implementation of BIP39. Thanks
-
Add BIP39 Elixir implementation (mnemo) 9256bbe82f
-
luke-jr added the label Proposed BIP modification on Feb 19, 2020
-
prusnak commented at 12:50 pm on February 20, 2020: contributorThe BIP is not supposed to be the list of all alternatives, but rather provide one really good implementation.
-
luke-jr closed this on Feb 20, 2020
-
aerosol commented at 2:33 pm on February 20, 2020: contributor@prusnak fair, yet unfair - JavaScript and Swift sections link to two implementations on that page. @izelnakri as the author of the currently linked implementation, would you mind looking at https://github.com/aerosol/mnemo and sharing your thoughts wrt code/tests quality? Cheers!
-
izelnakri commented at 5:47 pm on February 20, 2020: contributor@aerosol thanks for sharing your work. Could you create a PR with your improvements on https://github.com/izelnakri/mnemonic ? I can add you as a collaborator after we merge your improvements.
-
aerosol cross-referenced this on Feb 21, 2020 from issue Replace elixir bip39 implementation by aerosol
-
aerosol commented at 11:01 am on February 21, 2020: contributor@izelnakri Thanks for looking. Sorry, it’s not really feasible to do it chunks and I doubt you meant “submit a PR that replaces the whole repo”
-
Fatima-yo commented at 12:15 pm on February 21, 2020: none
Hi, I would like to add a new list of words (for a new language) to BIPS-39, how can I do?
Thanks in advance, Fatima
On Fri, 21 Feb 2020 at 08:01, Adam Rutkowski notifications@github.com wrote:
@izelnakri https://github.com/izelnakri Thanks for looking. Sorry, it’s not really feasible to do it chunks and I doubt you meant “submit a PR that replaces the whole repo”
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bips/pull/883?email_source=notifications&email_token=AA6FTCPZBHLK5RR52M3SJW3RD6YAPA5CNFSM4KLUE7Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMSK24A#issuecomment-589606256, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6FTCJ33RQRYTT6VYTKJ3DRD6YAPANCNFSM4KLUE7YQ .
–
Fatima Castiglione Maldonado
Ethernity software developers Complex software done Blockchain, Machine Learning, Web, Mobile
https://ethernity.live linkedin.com/in/fatima-castiglione-maldonado castiglionemaldonado@gmail.com (Email and Hangouts) +59892766400 (Voice, Signal, Line, Whatsapp) @Fatima_cm (Telegram) fatima.yo (Skype) fatimaflash (WeChat) UT5SP2WEL (Slack) Fatima#5608 (Discord)
=================================
-
iancoleman commented at 6:28 am on February 23, 2020: contributor
Have a look at the instructions at
https://github.com/bitcoin/bips/blob/master/bip-0039/bip-0039-wordlists.md
and also #863 for further info / context on new wordlists.
-
Fatima-yo commented at 2:20 pm on February 24, 2020: none
Thank you very much, I will do so today :-D
On Sun, 23 Feb 2020 at 03:28, iancoleman notifications@github.com wrote:
@Fatima-yo https://github.com/Fatima-yo
Have a look at the instructions at
https://github.com/bitcoin/bips/blob/master/bip-0039/bip-0039-wordlists.md
and also #863 https://github.com/bitcoin/bips/pull/863 for further info / context on new wordlists.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bips/pull/883?email_source=notifications&email_token=AA6FTCO5XZQE2ODDKMBXJZDREIJRRA5CNFSM4KLUE7Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMVS26I#issuecomment-590032249, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6FTCLIOMIH5FNBI7QYN3LREIJRRANCNFSM4KLUE7YQ .
–
Fatima Castiglione Maldonado
Ethernity software developers Complex software done Blockchain, Machine Learning, Web, Mobile
https://ethernity.live linkedin.com/in/fatima-castiglione-maldonado castiglionemaldonado@gmail.com (Email and Hangouts) +59892766400 (Voice, Signal, Line, Whatsapp) @Fatima_cm (Telegram) fatima.yo (Skype) fatimaflash (WeChat) UT5SP2WEL (Slack) Fatima#5608 (Discord)
=================================
-
Fatima-yo commented at 3:20 pm on February 24, 2020: none
Checking it now… From what I see, a good list would be like follows:
- Words are 4-8 letters long
- Words can be uniquely determined by typing the first 4 letters
- Words are sorting according to the Russian alphabet
- Priority on simple and common Russian words
- No words with more than one part
- No words in the plural
- No very similar words with 1 letter of difference
- No demonyms
- No personal names
- No geographical names
- No embarrassing words (in a very, very large scope)
- No words belonging to a particular religion
- No words that remind negative/sad/bad things
Would that set of rules be OK to add the list to BIP-0039 ? Kindly state.
Thanks in advance, Fatima
On Mon, 24 Feb 2020 at 11:20, Fatima Castiglione Maldonado < castiglionemaldonado@gmail.com> wrote:
Thank you very much, I will do so today :-D
On Sun, 23 Feb 2020 at 03:28, iancoleman notifications@github.com wrote:
@Fatima-yo https://github.com/Fatima-yo
Have a look at the instructions at
https://github.com/bitcoin/bips/blob/master/bip-0039/bip-0039-wordlists.md
and also #863 https://github.com/bitcoin/bips/pull/863 for further info / context on new wordlists.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bips/pull/883?email_source=notifications&email_token=AA6FTCO5XZQE2ODDKMBXJZDREIJRRA5CNFSM4KLUE7Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEMVS26I#issuecomment-590032249, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA6FTCLIOMIH5FNBI7QYN3LREIJRRANCNFSM4KLUE7YQ .
–
Fatima Castiglione Maldonado
Ethernity software developers Complex software done Blockchain, Machine Learning, Web, Mobile
https://ethernity.live linkedin.com/in/fatima-castiglione-maldonado castiglionemaldonado@gmail.com (Email and Hangouts) +59892766400 (Voice, Signal, Line, Whatsapp) @Fatima_cm (Telegram) fatima.yo (Skype) fatimaflash (WeChat) UT5SP2WEL (Slack) Fatima#5608 (Discord)
=================================
–
Fatima Castiglione Maldonado
Ethernity software developers Complex software done Blockchain, Machine Learning, Web, Mobile
https://ethernity.live linkedin.com/in/fatima-castiglione-maldonado castiglionemaldonado@gmail.com (Email and Hangouts) +59892766400 (Voice, Signal, Line, Whatsapp) @Fatima_cm (Telegram) fatima.yo (Skype) fatimaflash (WeChat) UT5SP2WEL (Slack) Fatima#5608 (Discord)
=================================
-
izelnakri commented at 9:59 pm on February 24, 2020: contributor
@izelnakri Thanks for looking. Sorry, it’s not really feasible to do it chunks and I doubt you meant “submit a PR that replaces the whole repo” @aerosol Im not convinced why it cant be done in chunks and requires a whole rewrite to my own repo. Just briefly checked your repo it isnt that big in terms of lines of code or complex to require a complete rewrite.
-
aerosol commented at 1:13 pm on February 25, 2020: contributor@izelnakri Thank you for your assessment. The primary motivation behind writing mnemo was to get a better understanding of BIP39. I found the pre-existing code difficult to reason about (one could say complex), hence I decided to start from scratch. If I had started by forking your repo, I’d happily submit a PR. Otherwise all I can see is two fundamentally different implementations - if you’re not convinced, have a look at the tests.
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 03:10 UTC
More mirrored repositories can be found on mirror.b10c.me