BIP155: Mention SHA3-256 explicitly #1002

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:200927-bip155-sha changing 1 files +4 −3

hebasto commented at 9:14 AM on September 27, 2020: member

It seems better to clarify that CHECKSUM in Tor onion v3 address uses SHA3-256 hash function.

in bip-0155.mediawiki:170 in a5a6a50725 outdated

 165 | @@ -166,10 +166,11 @@ onion_address = base32(PUBKEY | CHECKSUM | VERSION) + ".onion"
 166 |   CHECKSUM = H(".onion checksum" | PUBKEY | VERSION)[:2]
 167 |  
 168 |   where:
 169 | -   - PUBKEY is the 32 bytes ed25519 master pubkey of the hidden service.
 170 | +   - PUBKEY is the 32 bytes ed25519 master pubkey of the hidden service
 171 |     - VERSION is an one byte version field (default value '\x03')

jonatack commented at 10:56 AM on September 27, 2020:

While here, if you are inclined to, could s/an one/a one/ and remove the EOL whitespace at line 155: The new message introduces a separate network ID for <code>TORV2</code>.

hebasto commented at 11:09 AM on September 27, 2020:

Done.

jonatack commented at 11:00 AM on September 27, 2020: contributor

ACK per https://gitweb.torproject.org/torspec.git/tree/rend-spec-v3.txt#n163
BIP155: Mention SHA3-256 explicitly 562f1d7188
BIP155: Small text improvements 6ef71b344c
hebasto force-pushed on Sep 27, 2020
vasild commented at 2:48 PM on September 28, 2020: contributor

ACK 6ef71b344

Duplicating the Tor spec into this BIP does not seem very useful to me, but, ok, since we already have some of it, why not clarify what is H().
luke-jr assigned laanwj on Oct 5, 2020
luke-jr added the label Proposed BIP modification on Oct 5, 2020
laanwj commented at 12:32 PM on October 6, 2020: member

ACK 6ef71b344c51aebe1dab5ac47f87d8f926462a65 The reason part of the Tor spec is rehashed here is because the specific internals of the address format are relevant to the encoding.

On Mon, Oct 5, 2020, 19:24 Luke Dashjr notifications@github.com wrote:

Assigned #1002 https://github.com/bitcoin/bips/pull/1002 to @laanwj https://github.com/laanwj.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/bitcoin/bips/pull/1002#event-3841605011, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA65NV7XYQS7FYPJRDG5HDSJH6LDANCNFSM4R3OCQFQ .
laanwj merged this on Oct 6, 2020
laanwj closed this on Oct 6, 2020
hebasto deleted the branch on Oct 6, 2020

Contributors

Labels

Proposed BIP modification