Mention that public nonce is ''R'' and private nonce is ''s'' #1042

pull OrfeasLitos wants to merge 2 commits into bitcoin:master from OrfeasLitos:clarify-nonce changing 1 files +1 −1

OrfeasLitos commented at 12:37 PM on November 30, 2020: contributor

The terms "public/private nonce" are used in the Adaptor Signatures explanation without definition.
Say that public nonce is R and private nonce is s cf32b7bd39

in bip-0340.mediawiki:230 in cf32b7bd39 outdated

 226 | @@ -227,7 +227,7 @@ Moreover, Schnorr signatures are compatible with [https://web.archive.org/web/20
 227 |  
 228 |  === Adaptor Signatures ===
 229 |  
 230 | -[https://download.wpsoftware.net/bitcoin/wizardry/mw-slides/2018-05-18-l2/slides.pdf Adaptor signatures] can be produced by a signer by offsetting his public nonce with a known point ''T = t⋅G'', but not offsetting his secret nonce.
 231 | +[https://download.wpsoftware.net/bitcoin/wizardry/mw-slides/2018-05-18-l2/slides.pdf Adaptor signatures] can be produced by a signer by offsetting his public nonce ''R'' with a known point ''T = t⋅G'', but not offsetting his secret nonce ''s''.

jonasnick commented at 2:25 PM on November 30, 2020:

I understand "secret nonce" as referring to k. But I think that would be just as confusing if not more than without this PR. Perhaps not offsetting the signature's ''s'' value would be better.

Remove the term "secret nonce", only refer to s 23782b8693
jonasnick commented at 3:47 PM on November 30, 2020: contributor

looks good to me
sipa commented at 7:57 PM on November 30, 2020: member

ACK
luke-jr merged this on Feb 3, 2021
luke-jr closed this on Feb 3, 2021
OrfeasLitos deleted the branch on Nov 2, 2021

Contributors

OrfeasLitos

jonasnick

sipa