BIP 174: Reformat, reorganize, and mark final #1055

pull achow101 wants to merge 7 commits into bitcoin:master from achow101:reorganize-psbt changing 3 files +345 −385
  1. achow101 commented at 7:43 pm on January 14, 2021: member

    Pulls in most of the formatting changes from #953. Also explicitly specifies the parts for PSBT version 0 as well as sections for the process of adding new fields and PSBT versions. Lastly marks BIP 174 as final.

    Although I am marking it as final, this is only really for the general format. New fields can be added, and those fields should be added to the field listing tables in BIP 174.

  2. BIP 174: clarify format of proprietary extensions.
    "Variable length string identifier" is not defined anywhere, and the suggestion
    to use "0x00" is also deeply unclear.  I assumed it meant a nul-terminated
    string!
    
    Be explicit: you mean it must be a compact siz1\e unsigned int length, followed
    by that many identifier bytes, followed by a compact size unsigned int subtype,
    followed by optional keydata.
    
    Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
    6057fede05
  3. Reformat BIP 174 50fdf5435e
  4. achow101 force-pushed on Jan 14, 2021
  5. achow101 force-pushed on Jan 14, 2021
  6. achow101 force-pushed on Jan 14, 2021
  7. achow101 force-pushed on Jan 14, 2021
  8. Explicitly specify PSBTv0 c0991047e2
  9. Specify procedure for new fields and versions a4fb1b9de0
  10. Include PSBT versions that can or must include field 80df41818e
  11. achow101 force-pushed on Jan 15, 2021
  12. Mark BIP 174 as final c27d5e8b96
  13. Combine Appendix with field listing tables 88fb205264
  14. achow101 force-pushed on Jan 25, 2021
  15. achow101 cross-referenced this on Jan 28, 2021 from issue Add BIP 370: PSBT Version 2 by achow101
  16. luke-jr merged this on Feb 3, 2021
  17. luke-jr closed this on Feb 3, 2021

  18. luke-jr commented at 10:33 pm on February 3, 2021: member

    Argh, missed that this violates the length limit. Reverted that part.

    Please don’t modify CI to bypass validity checks.

  19. in bip-0174.mediawiki:589 in 88fb205264
    582@@ -509,6 +583,18 @@ Updaters and combiners that need to add a version number to a PSBT should use th
    583 For example, if a combiner sees two PSBTs for the same transaction, one with version 0, and the other with version 1, then it should combine them and produce a PSBT with version 1.
    584 If an updater is updating a PSBT and needs to add a field that is only available in version 1, then it should set the PSBT version number to 1 unless a version higher than that is already specified.
    585 
    586+===Procedure For New Fields===
    587+
    588+New fields should first be proposed on the bitcoin-dev mailing list.
    589+If a field requires significatn description as to its usage, it should be accompanied by a separate BIP.
    


    t-bast commented at 7:08 pm on February 10, 2021:
    nit: typo: significant
  20. Sjors cross-referenced this on Apr 30, 2021 from issue BIP 174 reformat WIP by rustyrussell

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 16:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me