docs: fix spelling #1117

pull jbampton wants to merge 2 commits into bitcoin:master from jbampton:fix-spelling changing 19 files +36 −36
  1. jbampton commented at 12:54 PM on May 7, 2021: contributor

    Another lot of spelling fixes and this has 53 additions and some that are not in the other PRs

    The other two PRs for typo fixes only have 28 and 21 additions.

    refs #579 refs #675

  2. docs: fix spelling 583e103ce4
  3. dr-orlovsky approved
  4. dr-orlovsky commented at 3:01 PM on May 7, 2021: contributor

    Confirm that PR contains only valid spelling changes into single words - and nothing else. Not sure whether in this case we need explicit ACK by authors of all those BIPs – probably multiple ACKs from independent ppl will do the job better. What do you think, @kallewoof and @luke-jr?

  5. michaelfolkson commented at 2:39 PM on May 8, 2021: contributor

    I'm not a fan of these bulk spelling fixes across a large number of different BIPs in a single PR if each minor change to a BIP needs to be ACKed by the BIP champion(s).

    I think going forward, we either allow minor spelling fixes to be merged without the BIP champion(s) being notified and ACKing them or we ask spelling fix PRs to only change one specific BIP at a time. The former would be a change to current BIP processes but perhaps could be included when we revise BIP processes at a future date.

    edit: Found this previous PR from @luke-jr to allow BIP editors to merge minor spelling changes without ACKs from BIP champion(s) and concerns were raised. Hence I think we should ask spelling fix PRs to only change one specific BIP at a time and not bundle spelling fixes across BIPs into one PR.

  6. kallewoof commented at 2:26 AM on May 9, 2021: member

    I think each PR should address a specific BIP and be approved by their respective authors.

  7. michaelfolkson commented at 10:50 AM on May 14, 2021: contributor

    I think each PR should address a specific BIP and be approved by their respective authors.

    I think these bulk spelling fix PRs across BIPs will need to be discouraged and eventually closed then. @luke-jr has also struggled to get BIP authors to care about minor spelling fixes. Thanks for the PR @jbampton but getting all the BIP champion(s) to ACK all the changes in a PR like this just isn't feasible.

  8. bitcoin deleted a comment on Jun 13, 2021
  9. luke-jr commented at 8:05 PM on July 2, 2021: member

    @dr-orlovsky It would be nice if BIP editors could just merge spelling changes, but unfortunately the current process requires each author to ACK.

  10. luke-jr added the label Proposed BIP modification on Jul 2, 2021
  11. kallewoof commented at 6:27 AM on July 6, 2021: member

    @dr-orlovsky It would be nice if BIP editors could just merge spelling changes, but unfortunately the current process requires each author to ACK.

    We should address this as part of the revised next process, IMO.

  12. 525411 approved
  13. bitcoin deleted a comment on Jan 22, 2022
  14. jonatack commented at 9:29 PM on April 23, 2024: contributor

    @jbampton This pull needs rebase due to merge conflicts in bip_0174.mediawiki and bip_0330.mediawiki that need to be resolved.

  15. murchandamus commented at 8:30 PM on April 30, 2024: contributor

    All of the changes in this PR fix only typos within a word across multiple BIPs, they do not change the meaning of any BIP.

    ACK 583e103ce467a31790ca299f97dc94c569ad01ae

  16. Merge branch 'master' into fix-spelling d9d6282fbb
  17. murchandamus commented at 8:52 PM on April 30, 2024: contributor

    I‘ve fixed the merge conflicts with BIP174 and BIP330 (where the passages in which the typo appeared had both been amended independently).

  18. murchandamus merged this on Apr 30, 2024
  19. murchandamus closed this on Apr 30, 2024

  20. jbampton deleted the branch on May 6, 2024

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 11:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me