[trivial]: Correct spellings across bips #675

pull Varunram wants to merge 4 commits into bitcoin:master from Varunram:typos changing 4 files +4 −4

Varunram commented at 5:47 AM on April 14, 2018: contributor

No description provided.
[trivial] Correct typos across bips 333a605d21
practicalswift commented at 9:57 AM on May 10, 2018: none

ACK 333a605d21c77002efb27aaf2fe352775f1bb3b0
luke-jr commented at 8:47 AM on May 20, 2018: member

BIP 35: @jgarzik BIP 60: @genjix ~~BIPs 11, 16, 61: @gavinandresen~~ BIPs 80 & 81: @justusranvier @jimmysong ~~BIPs 98, 116, 117: @maaku @kallewoof @btcdrak~~ ~~BIP 143: @jl2012 @sipa~~ BIP 152: @TheBlueMatt ~~BIP 157: @Roasbeef @aakselrod @jimpo~~ BIP 158: @Roasbeef @aakselrod BIP 174: @achow101 BIP 176: @jimmysong @practicalswift Why did you ACK this? You don't seem to be an author for any of the BIPs? O.o
luke-jr added the label Proposed BIP modification on May 20, 2018
practicalswift commented at 8:55 AM on May 20, 2018: none

@luke-jr I wasn't aware that only BIP authors were supposed to review typo fixes. Sorry about that! :-)
luke-jr commented at 9:17 AM on May 20, 2018: member

Yes, it's kind of a nuisance. I opened #596 a while back, but got push-back on the mailing list. :(
jimpo commented at 6:59 PM on May 20, 2018: contributor

ACK BIP 157
sipa commented at 7:05 PM on May 20, 2018: member

ACK BIP 143
kallewoof commented at 11:39 PM on May 20, 2018: member

ACK BIP 98, 116, 117.
gavinandresen commented at 11:37 AM on May 21, 2018: contributor

Perpetual ACK for all trivial changes that do not change the meaning of BIPs I wrote.
Varunram commented at 5:39 AM on June 20, 2018: contributor

ping @luke-jr, can I edit the PR just to include the BIPs which have been ACKed?
luke-jr commented at 6:08 AM on June 20, 2018: member

Please don't. That would reset the ACKs. I'll manually merge the applicable ones when I get a chance.
luke-jr commented at 5:15 AM on July 5, 2018: member

Merged BIPs 11, 16, 61, 98, 116, 117, 143, 157 in c3e8379b611a53114544b0ed7af5307b022b8ac8

Leaving open for the remaining BIPs (please don't rebase)
jgarzik commented at 2:50 PM on February 16, 2024: contributor

ACK, for my small part
murchandamus approved
murchandamus commented at 6:31 PM on April 30, 2024: contributor

Comparing against master, it appears that only four typos remain unfixed:

BIP 35: desireable ↦ desirable BIP 80: signfigant ↦ significant BIP 81: signfigant ↦ significant BIP 174: compatibilty ↦ compatibility

The merge-conflict appears to be due to another typo fix that got merged since this PR got opened. Given typos may be fixed now, I’m gonna merge this.
Merge branch 'master' into typos cb4296bd50
Fix shifted comma d8a59feee8
Update bip-0176.mediawiki 0999e407c8
murchandamus merged this on Apr 30, 2024
murchandamus closed this on Apr 30, 2024
murchandamus commented at 6:53 PM on April 30, 2024: contributor

I made a mistake in resolving the merge conflict with BIP-0176 and had to revert the change in another commit to avoid force pushing. I squashed the remaining for typos into master.

Contributors

Labels

Proposed BIP modification

Linked (view graph)

#1117 docs: fix spelling