Functions defined in the document refers to reference.py created in BIP340 and there the lift_x function accepts bytes and converts to int internally https://github.com/bitcoin/bips/blob/99701f68a88ce33b2d0838eb84e115cef505b4c2/bip-0340/reference.py#L71
remove int_from_bytes in lift_x call since it is done internally #1142
pull RCasatta wants to merge 1 commits into bitcoin:master from RCasatta:lift_x changing 1 files +1 −1-
RCasatta commented at 2:48 PM on July 14, 2021: contributor
-
remove int_from_bytes in lift_x call since it is done internally 9cf5c72b56
-
jonasnick commented at 5:31 PM on July 14, 2021: contributor
It seems like
lift_xas used in the mediawiki texts of both 340 and 341 takes an integer. Would be better to make them equal to the definition in 340reference.py. But I think your suggestion makes it a tiny bit more consistent because it's python code callingreference.pyfunctions.utACK 9cf5c72b569e321c0fc680b2a1ce0c3dd03c75af
- luke-jr merged this on Jul 20, 2021
- luke-jr closed this on Jul 20, 2021
