Currently the newline in list items in BIP-0158 is causing the text on the new line to be rendered as a code section. I am unsure why this is happening but putting all the text for each list item on a single line fixes it.
Remove newline to fix list rendering #1157
pull tcharding wants to merge 1 commits into bitcoin:master from tcharding:list-render changing 1 files +2 −4-
tcharding commented at 8:39 AM on August 17, 2021: contributor
-
aa206adf59
Remove newline to fix list rendering
Currently the newline in list items is causing the text on the new line to be rendered as a code section. I am unsure why but I'm guessing putting all the text for each list item on a single line will fix it.
-
kallewoof commented at 10:52 AM on August 17, 2021: member
Verified that the display issue exists and that the patch fixes rendering. I tested removing the whitespace after the newline but preserving the newline itself to see if that helped but it did not, so the suggested solution seems reasonable to me.
Minor nit if you're up for ACKing, @Roasbeef and/or @aakselrod
- luke-jr added the label Proposed BIP modification on Aug 29, 2021
- Lcote71 approved
-
tcharding commented at 12:06 AM on January 23, 2023: contributor
Friendly bump - I went to read the BIP again today, saw the issue, went to fix it, and realized I fixed it years ago :)
-
aakselrod commented at 6:09 PM on February 13, 2023: contributor
This looks good to me. :+1:
- kallewoof merged this on Feb 21, 2023
- kallewoof closed this on Feb 21, 2023
