This sentence is grammatically incorrect:
"Empirical analysis also shows that was chosen as these parameters ..."Elect to fix the sentence to be:
"Empirical analysis also shows that these parameters ..."[BIP 158] Fix grammar - remove 'was chosen as' #1158
pull tcharding wants to merge 1 commits into bitcoin:master from tcharding:gramar-fix-bip-158 changing 1 files +3 −3-
tcharding commented at 8:48 AM on August 17, 2021: contributor
-
724a688cf9
Fix grammar - remove 'was chosen as'
This sentence grammatically incorrect Empirical analysis also shows that was chosen as these parameters ... Elect to fix the sentence to be: Empirical analysis also shows that these parameters ...
- luke-jr renamed this:
Fix grammar - remove 'was chosen as'
[BIP 158] Fix grammar - remove 'was chosen as'
on Aug 29, 2021 -
luke-jr commented at 9:22 PM on August 29, 2021: member
- luke-jr added the label Proposed BIP modification on Aug 29, 2021
-
tcharding commented at 9:17 AM on August 30, 2021: contributor
Oh is that a thing to put the BIP number on the commit/PR subject line? I'll do that for you in future.
- Roasbeef approved
-
Roasbeef commented at 7:07 PM on August 30, 2021: contributor
LGTM 🌋
- kallewoof merged this on Aug 31, 2021
- kallewoof closed this on Aug 31, 2021
