Update BIP39 Add reference to a .NET implementation #126

Hello, I have added a reference to my .NET implementation of BIP39 into the specification documentation.

I am writing "modules" in .NET that can be maintained independently without having to do full blown upgrades etc. when one spec changes or whatever. So I have my BitcoinUtilities module which provides the BouncyCastle crypto stuff and then any other shared functionality between modules and I will be writing modules for BIPS as I have done for BIP39. I have wrote a module (KeyCore) which does the legacy style private keys where each key is formed from a crypto random 32 byte seed, Then can determine the WIF/WIF Compressed and the two addresses from the seed, however I realise everyone is heading to HD wallets and I plan to write a BIP32 module as well.

This BIP39 module is correct for all the English test vectors, has unit tests to test as much and I have thoroughly documented my code. Also providing a demo GUI to demonstrate usage.

This is a PCL so it will work on all modern platforms, Windows Phone, Windows RT, Windows Desktop etc. (Demo GUI is Windows Desktop for maximum compatibility as people may not have Windows Phone SDK etc).

Where the pullers at? ;P

Ping @slush0 @voisine @ebfull

Here is image of Demo Gui. One could actually use this to create mnemonic sentences to provide seed bytes etc. if they wished, as it has been designed to show how you would use it.

Please use a more descriptive commit message, "Update bip-0039.mediawiki" doesn't tell much.

This is my first pull ever.....it just put that stuff there which is why I wrote the comment there explaining what I was doing? Do you pull stuff based on the title or what? Do I have to find a way to edit the title before you'll pull it is that what you're saying?

Edited the title is that descriptive enough?

Hmmm guess I didn't make it descriptive enough then?

Cool, thanks! I don't do .NET, but any implementation covered by unit tests is welcome!

No worries! Yea all English test vectors pass :) If you would like to fire it up and verify as much, happy to help you get setup in Visual Studio :)

@slush0 unfortunately it would appear that implementations are not welcome unless you meet some kind of selection criteria in the pull request title as per @laanwj remarks and no actions of it being merged/pulled whatever you call it.

@Thashiznets The commit message should explain what is being changed...

@luke-jr is the commit message the title? because I did write a message at the time of commit (first in this thread) specifying what I'd done etc. And this is my first ever contribution to anything and it auto generated the title to be update bips39 blah blah and I thought that the title was acceptable as it was an update to the bips39 and I described what I was updating in the comments here? Titles could surely get quite large if you had to describe everything you were doing in a title surely? However I did amend the title in any case to describe what is being achieved as it is such a subtle update it fits in the title easily.

"Add reference to a .NET implementation" would be perfectly acceptable as commit message.

So I know I'm on the same page, is the title the commit message? Or is the message I write here independent of the title the commit message?

This is a pull request, it's a github thing where you describe why you want to have some change accepted.

The commit message is the message on the change that becomes part of the repository. The commit message is currently:

Update bip-0039.mediawiki

Hello, I have created a .NET version of the BIP39 specification for the community. It is a Portable Class Library so it can be used in anything newish .NET so Windows Phone, WinRT, full blown .NET 4.5 etc.

I assume the request is to change the "Update bip-0039.mediawiki" to something like "Add reference to .NET implementation of BIP39". The message that follows doesn't really belong there.

Ah ok I see, so I have mentioned what I'm doing but not what I'm changing in the doco in that message. Where can I find that message to alter it?

Actually I see that message under the "commits" tab, but it seems there is no way for me to edit it :( Shall I open a new pull request? Or can we agree that I will be more vigilant next time and I shall seek to specify changes in the commit message next time I contribute something and allow this one through this time, chalking it up to my inexperience as it was my first time contributing and I didn't really know.

@Thashiznets I guess you created this PR (including the editing of the file from github) - you'll have to use git to change the commit message, I don't think you can do that from github.

or just close this and do it again ... (which might be easier for you)

If you want to try doing it from the command line that would be something like: git clone git@github.com:Thashiznets/bips.git cd bips git checkout patch-1 git commit --amend now you should be prompted to edit the message git push -f origin patch-1

warning pushing with force (-f) overwrites what is on github, you should always be careful doing this and try to avoid doing it on branches where you work together with other people.

"Clone failed. Cannot fetch branches and objects. See console output for details."

Console Output: "fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists."

Look this is ridiculous. I'm no longer going to bother, It's not like there is any incentive for me to contribute I just wanted to......but seeing as you clearly don't want me to contribute...no worries.....haters gonna hate I suppose! Fark no wonder Bitcoin is flailing.......if you're that petty that you don't let someone contribute based on such a small thing as they erroneously type a different comment than you expect on their first ever contribution, what hope does a crypto currency have. You have fun killing off anyone that shows an interest in it and perhaps doesn't use linux and/or python and your other tools like git (I'm aware Visual Studio is using git tools in the background, but that is not me) and still expect it to grow.......#dumb

(Thank you to those that tried to help me bypass/please the bureaucracy)

@rubensayshi you guess correctly. I used the web interface on this site. I haven't used git a day in my life, Visual Studio does all the stuff for me. With my repositories, I create them on this site, I put the link from this site in Visual Studio and it does the rest. I click commit to package my code to my repository then click sync and it makes sure what is on my computer is the same as what's on github. That simple......none of this type this here do that there.....this is what makes Visual Studio so great.

Thank you for trying to help me tho.

Just delete this PR and create new one. No neeed to fight git at all.

On Tue, Dec 16, 2014 at 4:11 AM, Thashiznets notifications@github.com wrote:

Closed #126 #126.

Reply to this email directly or view it on GitHub #126#event-208058543.

You could also just have asked if one of us would handle it for you. I'd have been glad to. But if you want to get rude, well have fun, I'm not going to bother.

@laanwj I thought I did handle it? I thought the title was the commit message and I edited it and asked if it was better and you said nothing? How was I supposed to know what the commit message was? And several people as you can see did come on here and try to help me....so after instruction by them I was still not able to achieve what you desired......yea good one mate....I'm the rude one. And if you were glad to edit it how you wanted it, why didn't you just go ahead and do that seeing as it is you that has the issue with it??? I didn't even know that I had edited the incorrect part, let alone that the part you expected me to change was not even editable from the GUI I used to create it.....

I'm very busy and I don't monitor all these issues 24/7. I also have no obligation to. But if I had seen this it'd be kind of easy to change the message while merging. Anyhow those silly rants don't really speak in your favor, I don't want to help you.

That's the thing....you're not helping me.....I was not contributing for myself.....#duh

But you have an obligation to enforce that I type the right message in the thingy? So you like to take on an authority with no obligation to help anyone who doesn't meet your criteria? It's not a rant dude.....that's all about it.

Hey, just drop the PR, create new one and stop crying here.

On Tue, Dec 16, 2014 at 7:32 AM, Thashiznets notifications@github.com wrote:

That's the thing....you're not helping me.....I was not contributing for myself.....#duh

But you have an obligation to enforce that I type the right message in the thingy? So you like to take on an authority with no obligation to help anyone who doesn't meet your criteria? It's not a rant dude.....that's all about it.

Reply to this email directly or view it on GitHub #126 (comment).

@slush0 are you serious? There is no point, old mate has decided he "doesn't want to help me" ..... and since he has to approve it, it would be a waste of time..... It would just sit there again.

I don't consider clicking the merge button "helping" that goes automatic. I just want to make sure that the commit messages make sense to someone looking at the history (ie git log). If you submit a new pull that is the same as this one but with the right commit message I'll merge it immediately.

Ok fine @slush0 done! :)