Wallet Labels Export Format #1383

pull craigraw wants to merge 12 commits into bitcoin:master from craigraw:wallet-labels changing 1 files +131 −0
  1. craigraw commented at 10:02 am on October 17, 2022: contributor

    This was first proposed on the mailing list on Aug 24 as a common format for the export and import of wallet labels.

    Following discussion there, on this bitcointalk post and via private channels with other wallet developers, the original proposal was simplified, and changed to use JSON instead of CSV. The revised proposal has been well received, and I believe is ready for consideration as a BIP.

    Link: https://github.com/craigraw/bips/blob/master/bip-wallet-labels.mediawiki

  2. initial commit c497b95372
  3. fix formatting d81452fbae
  4. add importing section 80c44a97a9
  5. clarify csv preference 71243cbf07
  6. tabs to spaces e09061aeb2
  7. add rationale and references, require that rfc4180 is followed 1689d24e88
  8. fix reference links a8261e3c39
  9. show reference links as list 6bf0390b53
  10. use self describing json lines format instead of csv 7f0024405c
  11. Merge branch 'bitcoin:master' into wallet-labels da09065f39
  12. abdul-hannan1 commented at 1:32 am on October 27, 2022: none
    I have address bsc
  13. manda2020panda approved
  14. craigraw cross-referenced this on Dec 12, 2022 from issue [Feature Request] Import/Export UTXO Labels by heredia21
  15. moneymanolis approved
  16. moneymanolis commented at 5:57 pm on December 15, 2022: none
    What’s blocking the merge of this?
  17. moneymanolis cross-referenced this on Dec 15, 2022 from issue Transaction labels are misleading by moneymanolis
  18. k9ert approved
  19. kallewoof added the label New BIP on Jan 4, 2023
  20. in bip-wallet-labels.mediawiki:82 in da09065f39 outdated
    77+| Address in base58 or bech32 format
    78+| <tt>bc1q34aq5drpuwy3wgl9lhup9892qp6svr8ldzyy7c</tt>
    79+|-
    80+| <tt>pubkey</tt>
    81+| 32 or 33 byte public key in hexadecimal format
    82+| <tt>0283409659355b6d1cc3c32decd5d561abaac86c37a353b52895a5e6c196d6f448</tt>
    


    luke-jr commented at 4:25 pm on January 16, 2023:
    What about 65-byte pubkeys?

    craigraw commented at 5:06 pm on January 16, 2023:
    Good point, added.
  21. luke-jr commented at 4:33 pm on January 16, 2023: member
    Assigned BIP 329
  22. add bip number and accommodate 65 byte pubkeys d6fb6424ae
  23. craigraw commented at 5:08 pm on January 16, 2023: contributor
    Edited to assign BIP number 329. Pinging @kallewoof
  24. fix comments uri 32ba2ffe6f
  25. kallewoof merged this on Jan 16, 2023
  26. kallewoof closed this on Jan 16, 2023

  27. dipunm commented at 11:07 am on January 17, 2023: none

    I get that this is closed, but am new to commenting on bips so I’ll add my comment here.

    An importing wallet may ignore records it does not store, and truncate labels if necessary.

    I think adding truncation as a standard is dangerous. Context can be lost, especially if context was at the end. Also different apps may have further restrictions such as character limitations (no emoticon support or Chinese character support)

    Is it not more appropriate to warn that care should be taken if truncating or modifying the label and/or a warning should be given if any modifications will be made. UI is up to the app.

    Something like that?

  28. Transisto cross-referenced this on Mar 16, 2023 from issue Label export / import BIP-329 by Transisto

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-03 17:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me