- add more recent links to descriptor related BIPs
- explicitly specify LF as newline control character
- explicitly specify unit for
dklen
variable
Update bip-0129.mediawiki #1390
pull scgbckbone wants to merge 1 commits into bitcoin:master from scgbckbone:update_bip129 changing 1 files +5 −2-
scgbckbone commented at 0:51 am on November 22, 2022: contributor
-
update bip-0129.mediawiki 9df0b19c24
-
katesalazar commented at 8:30 pm on April 23, 2024: contributor@hugohn [does Coinkite Peter claim any GitHub user account, couldn’t find it] @benma @aaronisme @nvk
-
murchandamus added the label Pending acceptance on Apr 26, 2024
-
murchandamus added the label Proposed BIP modification on Apr 26, 2024
-
murchandamus commented at 9:33 pm on April 26, 2024: contributor
The gist of this change seems reasonable, but I am not intimately familiar enough with BIP129 to spontaneously assess whether all the linked BIPs are relevant.
It would seem to be best if one of the BIPs authors were to review and endorse this.
-
scgbckbone commented at 12:39 pm on April 27, 2024: contributor
does Coinkite Peter claim any GitHub user account, couldn’t find i @doc-hex
-
hugohn commented at 1:10 pm on April 27, 2024: contributor
Looks good to me !
ACKed.
-
in bip-0129.mediawiki:50 in 9df0b19c24
46@@ -47,11 +47,14 @@ Concerns #4 and #5 should be handled by Signers and are out of scope of this pro 47 ==Specification== 48 49 ===Prerequisites=== 50-This proposal assumes the parties in the multisig support [https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki BIP-0032], [https://github.com/bitcoin/bips/blob/master/bip-0322.mediawiki BIP-0322], [https://github.com/bitcoin/bitcoin/blob/master/doc/descriptors.md the descriptor language] and [https://tools.ietf.org/html/rfc3686 AES encryption]. 51+This proposal assumes the parties in the multisig support [https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki BIP-0032], [https://github.com/bitcoin/bips/blob/master/bip-0322.mediawiki BIP-0322], [https://github.com/bitcoin/bips/blob/master/bip-0380.mediawiki BIP-0380 Output Script Descriptors] ([https://github.com/bitcoin/bips/blob/master/bip-0381.mediawiki BIP-0381],[https://github.com/bitcoin/bips/blob/master/bip-0382.mediawiki BIP-0382],[https://github.com/bitcoin/bips/blob/master/bip-0383.mediawiki BIP-0383]) and [https://tools.ietf.org/html/rfc3686 AES encryption].
jonatack commented at 1:37 pm on April 27, 2024:0This proposal assumes the parties in the multisig support [https://github.com/bitcoin/bips/blob/master/bip-0032.mediawiki BIP-0032], [https://github.com/bitcoin/bips/blob/master/bip-0322.mediawiki BIP-0322], [https://github.com/bitcoin/bips/blob/master/bip-0380.mediawiki BIP-0380 Output Script Descriptors] ([https://github.com/bitcoin/bips/blob/master/bip-0381.mediawiki BIP-0381], [https://github.com/bitcoin/bips/blob/master/bip-0382.mediawiki BIP-0382], [https://github.com/bitcoin/bips/blob/master/bip-0383.mediawiki BIP-0383]) and [https://tools.ietf.org/html/rfc3686 AES encryption].
jonatack commented at 1:39 pm on April 27, 2024: contributorACK
One nit for a possible follow-up.
jonatack renamed this:
update bip-0129.mediawiki
Update bip-0129.mediawiki
on Apr 27, 2024jonatack merged this on Apr 27, 2024jonatack closed this on Apr 27, 2024
bitcoin deleted a comment on Apr 27, 2024
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 13:10 UTC
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 13:10 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me