Mark Taproot BIPs as Final #1423

1. 
   uncomputable commented at 3:21 pm on February 19, 2023: contributor

   Taproot is supported by Bitcoin Core and adopted by a majority of the network, so it should be marked as Final. The progression from Draft to Proposed and from Proposed to Final was likely forgotten.
2. Mark Taproot BIPs as Final 43fa7cf13d
3. Fkhaibari approved
4. bitcoin deleted a comment on Feb 19, 2023
5. real-or-random approved
6. 
   real-or-random commented at 6:19 pm on February 19, 2023: contributor

   ACK 43fa7cf13d3ed35bcd2dd518c2fa0f41a4d2caa7
7. 
   jonasnick commented at 7:34 pm on February 19, 2023: contributor

   ACK 43fa7cf13d3ed35bcd2dd518c2fa0f41a4d2caa7
8. 
   augustoproiete commented at 3:01 am on February 20, 2023: none

   ACK 43fa7cf
9. 
   ajtowns commented at 1:17 am on February 21, 2023: contributor

   Is Final meant to imply it won’t change any more? If so, should merge/nack pending fixes like #1406 and #1329 first? Otherwise, if fixes of that nature are still okay, ACK.
10. 
    kallewoof commented at 1:44 am on February 21, 2023: member

    I interpret ‘final’ as something that is adopted and in use, as opposed to a proposal, which is not yet (widely non-experimentally) used. So I think fixes post-final state are fine.
11. 
    luke-jr commented at 5:15 pm on February 21, 2023: member

    You forgot BIP 343, which was used to activate Taproot.
12. Mark BIP 343 as Final f4a05c1ced
13. 
    uncomputable commented at 9:09 pm on February 21, 2023: contributor

    Thanks for pointing this out. I added a new commit. Not everyone seems to want to finalize BIP 343, so we can merge with or without it.
14. 
    jonasnick commented at 9:49 pm on February 21, 2023: contributor

    CC @michaelfolkson
15. 
    michaelfolkson commented at 10:15 pm on February 21, 2023: contributor

    CC @michaelfolkson

    Personally I’m not bothered. I agree BIP 340-342 should be made Final. BIP 343 should also be made Final. Activation mechanism(s) seem to me to be entirely independent to the proposal(s) they are activating. I looked up SegWit activation BIPs and they were made Final in an independent pull request (#571) to the SegWit BIPs.

    So happy to open an independent pull request to this one to make BIP 343 Final if that is what is blocking this.

16. michaelfolkson cross-referenced this on Feb 21, 2023 from issue Mark BIP343 as Final by michaelfolkson
17. 
    michaelfolkson commented at 11:37 pm on February 21, 2023: contributor

    ACK f4a05c1ced66f9f6a10fb1d741648dbe5be10301

    Or alternatively remove the BIP 343 commit and merge #1426 instead. Either is fine with me.

18. tcooksey1972 approved
19. 
    uncomputable commented at 2:13 pm on February 26, 2023: contributor

    Any opinions? Otherwise, let’s merge it with BIP 343 included. We can squash the two commits to finalize all three BIPs at the same time, if that is an issue.
20. kallewoof merged this on Feb 26, 2023
21. kallewoof closed this on Feb 26, 2023

    ---

Contributors
uncomputable Fkhaibari real-or-random jonasnick augustoproiete ajtowns kallewoof luke-jr michaelfolkson tcooksey1972