Cleans up the README table, particularly after merge of bip 327.
Cleanup README table #1438
pull ajtowns wants to merge 4 commits into bitcoin:master from ajtowns:202303-tests changing 4 files +9 −8-
ajtowns commented at 11:56 PM on March 27, 2023: contributor
-
kallewoof commented at 12:14 AM on March 28, 2023: member
Thanks. I don't think this needs ACKs from authors except maybe for the BIP-327 change:
- BIP-326 title fix aligns with the BIP itself
- BIP-157 fix reflects the actual status of the BIP
- BIP-327 fix makes slight alternation to title to fit width max, but the change is trivial and does not change the meaning in any way
-
ajtowns commented at 12:19 AM on March 28, 2023: contributor
cc @jonasnick @real-or-random @robot-dreams for BIP-327 title tweak (replace "for" with ":")
-
real-or-random commented at 2:51 AM on March 28, 2023: contributor
cc @jonasnick @real-or-random @robot-dreams for BIP-327 title tweak (replace "for" with ":")
To be honest, I prefer the "for". We'll come back to you, maybe there's another way to get it down one char.
-
ajtowns commented at 3:27 AM on March 28, 2023: contributor
To be honest, I prefer the "for". We'll come back to you, maybe there's another way to get it down one char.
Could change "multi-signature" to "multisignature" throughout the bip, matching bip340's spelling? EDIT: I guess that diverges from the paper's spelling which would be annoying. Could just drop the "-compatible" entirely?
-
jonasnick commented at 10:49 AM on March 28, 2023: contributor
BIP-327 fix makes slight alternation to title to fit width max, but the change is trivial and does not change the meaning in any way
Is it not possible to adjust the width max? The table in master looks fine at first glance (in my browser).
-
kallewoof commented at 4:41 AM on March 29, 2023: member
Yes, that's a possible solution too. I'm not sure why it was set to this specific value, though.
-
BIP327: fixups for buildtable.pl 0e5b18c0ff
-
README markup fixes 469ccc9617
-
BIP157 was replaced in PR#1378 cbfdce0430
-
Use BIP-326 title from PR#1314 in README 9e4c055a74
- ajtowns force-pushed on Mar 29, 2023
-
ajtowns commented at 5:14 AM on March 29, 2023: contributor
Added 327 to the title length exceptions list, so that CI can go back to passing without needing to wait for an extended debate about titles...
- kallewoof merged this on Mar 29, 2023
- kallewoof closed this on Mar 29, 2023
Contributors