bip-0324: fix git instruction order in test_sage_decoding.py #1471

pull theStack wants to merge 1 commits into bitcoin:master from theStack:fix_bip324_test_sage_decoding_git_instrs changing 1 files +1 −1
  1. theStack commented at 2:40 pm on July 6, 2023: contributor
    Tiny fix correcting the order of commands, for git checkout one has to change into the repository directory first.
  2. bip-0324: fix git instruction order in test_sage_decoding.py
    Tiny fix correcting the order of commands, for `git checkout` one has
    to change into the repository directory first.
    9f25645be5
  3. stratospher commented at 7:18 am on July 7, 2023: contributor
    (unrelated to this PR but related to BIP 324) - you could also remove https://github.com/bitcoin/bips/blob/master/bip-0324/xswiftec_test_vectors.csv maybe? xswiftec_test_vectors.csv isn’t being used anywhere and I’d assume it’s a leftover from the previous revision of the doc which replaced it with xswiftec_inv_test_vectors.csv(currently used).
  4. luke-jr added the label Proposed BIP modification on Jul 9, 2023
  5. luke-jr commented at 5:45 pm on July 9, 2023: member
  6. sipa commented at 5:54 pm on July 9, 2023: member
    LGTM
  7. real-or-random approved
  8. real-or-random commented at 4:33 pm on July 10, 2023: contributor
    ACK 9f25645be58f4db49cc2ae5a0a8ceca241517767
  9. murchandamus merged this on Apr 26, 2024
  10. murchandamus closed this on Apr 26, 2024


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-02-05 16:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me