BIP-0002 Fix broken anchor link #1474

pull azuchi wants to merge 1 commits into bitcoin:master from azuchi:fix-bip-2-broken-link changing 1 files +2 −2

azuchi commented at 8:16 AM on July 10, 2023: contributor

No description provided.
BIP-0002 Fix broken anchor link 0792d51017
katesalazar commented at 8:56 PM on July 10, 2023: contributor
it's not broken, it's reasonably salvaged

On Mon, Jul 10, 2023 at 8:17 AM shigeyuki azuchi @.***> wrote:
You can view, comment on, or merge this pull request online at:

#1474 Commit Summary

0792d51 https://github.com/bitcoin/bips/pull/1474/commits/0792d51017e34f9a249c0d9613f0cfbd17544e31 BIP-0002 Fix broken anchor link

File Changes

(1 file https://github.com/bitcoin/bips/pull/1474/files)

M bip-0002.mediawiki https://github.com/bitcoin/bips/pull/1474/files#diff-bdc8d36298e0974a62d5ed5dc5dfa746382cb31034a3bc7ba5d193c343fa8945 (4)

Patch Links:

#1474.patch

#1474.diff

— Reply to this email directly, view it on GitHub https://github.com/bitcoin/bips/pull/1474, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W3BASLSKD7J7AKYQ2DXPO3ATANCNFSM6AAAAAA2EFN34Q . You are receiving this because you are subscribed to this thread.Message ID: @.***>
19861826 approved
19861826 approved
Jones098 approved
luke-jr commented at 12:41 AM on July 18, 2023: member

Seems like this is a bug in GitHub's mediawiki renderer
sasa-buklijas commented at 8:46 AM on July 18, 2023: none

Seems like this is a bug in GitHub's mediawiki renderer

Probably, because I have see same problem in #1476 and some other(not Bitcoin) markdown files also on github

It is strange when links are not working correctly and then you spend some time troubleshooting, special if you are not aware of this nuisance.

But I am not sure was this default behaviour on github on some bug introduced later. In official doc it is not mentioned, only found unofficial/user gist.

As I said this is just nuisance, if there is decision to change it in all BIPs, I am willing to make tool for automatic detection and then open pull request for each BIP where links are broken.
azuchi commented at 1:52 AM on July 22, 2023: contributor

As I said this is just nuisance, if there is decision to change it in all BIPs, I am willing to make tool for automatic detection and then open pull request for each BIP where links are broken.

I see. close this.
azuchi closed this on Jul 22, 2023

Contributors