BIP327: Fix Broken Links #1549

pull siv2r wants to merge 1 commits into bitcoin:master from siv2r:bip327-fix-link changing 1 files +4 −4

siv2r commented at 5:56 AM on February 1, 2024: contributor
- Negation Of The Seckey When Signing link
  
  add the missing "#"
- Indentifiying Disruptive Signers link
  
  remove “i” after “f”
- Signing Flow link
  
  should be General Signing Flow instead
vostrnad commented at 8:00 AM on February 1, 2024: contributor

ACK 1dbf71b3dace52d8c89cc7a73471d1c600c3fa14
jonasnick approved
jonasnick commented at 7:56 PM on February 2, 2024: contributor

Thanks.

ACK 1dbf71b3dace52d8c89cc7a73471d1c600c3fa14
0xGRAV3R approved
0xGRAV3R commented at 10:51 PM on February 23, 2024: none

checked and reviewed the three changes & fixes for the broken links and these are good to go
0xtrr approved
0xtrr commented at 6:12 PM on February 24, 2024: none

Ack. Verified that the updated links didn't work before and works as expected now.
bip327: fix broken links ddf5b25fc7
siv2r force-pushed on Feb 26, 2024
siv2r commented at 11:52 AM on February 26, 2024: contributor

Added the following fix too:

The link for mandatory pk in nonce gen should redirect to the "signing with tweaked individual keys" section, not "modification to nonce generation".
jonasnick commented at 1:27 PM on February 26, 2024: contributor

ACK ddf5b25

Same fix is also in #1544 (do you want to close that @real-or-random?).
jonasnick approved
real-or-random approved
real-or-random commented at 1:49 PM on February 26, 2024: contributor

ACK ddf5b25fc7f8009fa46ccb94f9ea73e85feffbf5
real-or-random commented at 1:51 PM on February 26, 2024: contributor

Thanks @siv2r!

Hint: In this repo, it makes sense to @mention the BIP authors in any PRs and issues. I wasn't aware of this PR. (It's not possible to enable notifications for single BIPs, you can only do it for the entire repo...)
kristapsk approved
kristapsk commented at 1:55 PM on February 26, 2024: none

ACK ddf5b25fc7f8009fa46ccb94f9ea73e85feffbf5
siv2r commented at 5:39 PM on February 26, 2024: contributor

Same fix is also in #1544

Sorry missed this PR.
Originalmenace approved
jonatack approved
jonatack commented at 4:27 PM on April 22, 2024: contributor

ACK
jonatack merged this on Apr 22, 2024
jonatack closed this on Apr 22, 2024
bitcoin deleted a comment on Apr 23, 2024
siv2r deleted the branch on Apr 23, 2024

Contributors

Linked (view graph)

#1544 bip327: Link to right section