Typo bip-0340.mediawiki #1630
pull thesimplekid wants to merge 1 commits into bitcoin:master from thesimplekid:patch-1 changing 1 files +1 −1-
thesimplekid commented at 11:06 pm on July 1, 2024: none
-
Typo bip-0340.mediawiki 00714d1357
-
in bip-0340.mediawiki:212 in 00714d1357
208@@ -209,7 +209,7 @@ The algorithm ''BatchVerify(pk<sub>1..u</sub>, m<sub>1..u</sub>, sig<sub>1..u</s 209 ** Let ''e<sub>i</sub> = int(hash<sub>BIP0340/challenge</sub>(bytes(r<sub>i</sub>) || bytes(P<sub>i</sub>) || m<sub>i</sub>)) mod n''. 210 ** Let ''R<sub>i</sub> = lift_x(r<sub>i</sub>)''; fail if ''lift_x(r<sub>i</sub>)'' fails. 211 * Fail if ''(s<sub>1</sub> + a<sub>2</sub>s<sub>2</sub> + ... + a<sub>u</sub>s<sub>u</sub>)⋅G ≠ R<sub>1</sub> + a<sub>2</sub>⋅R<sub>2</sub> + ... + a<sub>u</sub>⋅R<sub>u</sub> + e<sub>1</sub>⋅P<sub>1</sub> + (a<sub>2</sub>e<sub>2</sub>)⋅P<sub>2</sub> + ... + (a<sub>u</sub>e<sub>u</sub>)⋅P<sub>u</sub>''. 212-* Return success iff no failure occurred before reaching this point. 213+* Return success if no failure occurred before reaching this point.
jonatack commented at 1:06 am on July 2, 2024:This is not a typo. See, for instance:
jonatack commented at 1:11 am on July 2, 2024:If you search this repo, you’ll see “iff” used in 3 other places.
0bip-0327.mediawiki:490:* Return success iff no failure occurred before reaching this point. 1bip-0327.mediawiki:505:* Return success iff no failure occurred before reaching this point. 2bip-0340.mediawiki:189:* Return success iff no failure occurred before reaching this point. 3bip-0340.mediawiki:212:* Return success iff no failure occurred before reaching this point.
jonatack commented at 1:08 am on July 2, 2024: contributorThank you for your proposal. Closing for the reason given in #1630 (review).jonatack closed this on Jul 2, 2024
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-02 13:10 UTC
This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-12-02 13:10 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me