BIP 324: fix python aad in complete_handshake #1655

1. 
   Crypt-iQ commented at 3:56 pm on July 26, 2024: contributor

   The aad shouldn’t include the garbage terminator. This tripped me up during implementation even though the text says it shouldn’t be included.
2. BIP 324: fix python aad in complete_handshake 0963e43860
3. 
   jonatack commented at 4:07 pm on July 26, 2024: member

   Initial ACK, appears to correspond to

   • https://github.com/bitcoin/bitcoin/blob/master/src/net.cpp#L1158
   • https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/v2_p2p.py#L196

   cc @sipa, @real-or-random, @stratospher

4. jonatack added the label Proposed BIP modification on Jul 26, 2024
5. jonatack added the label Pending acceptance on Jul 26, 2024
6. 
   stratospher commented at 4:04 am on July 27, 2024: contributor

   ACK 0963e43. we only authenticate garbage (and not garbage terminator) as mentioned in the BIP text.
7. 
   jonatack commented at 2:01 pm on July 27, 2024: member

   ACK 0963e43860e2c8e41c0821e2bc442bdd337a0ded

   As implemented in Bitcoin Core and in its functional tests, and per line 360 of the BIP:

   Both the initiator and the responder set the AAD of the first encrypted packet they send after the garbage terminator (i.e., either an optional decoy packet or the version packet) to the garbage they have just sent, not including the garbage terminator.

8. jonatack merged this on Jul 27, 2024
9. jonatack closed this on Jul 27, 2024

   ---

10. jonatack removed the label Pending acceptance on Jul 27, 2024
11. jonatack removed the label Proposed BIP modification on Jul 27, 2024
12. jonatack added the label Bug fix on Jul 27, 2024
13. Crypt-iQ deleted the branch on Jul 27, 2024

Contributors
Crypt-iQ jonatack stratospher

Labels
Bug fix