Minor spelling/grammar fixups in BIPs 372 and 381 #1720

pull HubertIGL wants to merge 3 commits into bitcoin:master from HubertIGL:master changing 3 files +4 −4
  1. HubertIGL commented at 4:33 AM on December 17, 2024: contributor

    Changes to bip-0372.mediawiki:

    "involve" → "evolve" Corrects word choice as "evolve" better describes the progressive development of standards

    "addresses" → "addressed" Fixes verb tense to match the passive voice construction

    "Appenxix" → "Appendix" Fixes misspelling of "Appendix"


    Changes to bip-0381.mediawiki:

    "acceps" → "accepts" Fixes misspelling of "accepts"


    Changes to bip-0384.mediawiki:

    "implementation" → "implementations" Changes to plural form as it refers to multiple possible implementations

  2. Update bip-0372.mediawiki e1a3a0606d
  3. Update bip-0381.mediawiki d02146cdaf
  4. Update bip-0384.mediawiki 50f06e9604
  5. in bip-0372.mediawiki:124 in 50f06e9604
     120 | @@ -121,7 +121,7 @@ P2C tweaks commit to external data, some of which may represent certain value
     121 |  (like in some sidechains, single-use-seal applications like RGB etc). Creation
     122 |  of such outputs much allow hardware devices to understand the structure of such
     123 |  extra-transaction data, which may be in different formats and constantly
     124 | -involve. Thus, this should be addresses with a separate standards (or be a
     125 | +evolve. Thus, this should be addressed with a separate standards (or be a
    


    jonatack commented at 1:30 PM on December 17, 2024:

    While touching this paragraph, there are other fixups that can be made:

     The scope of this proposal is deliberately kept narrow; it addresses
     only spending of transaction outputs containing P2C tweaks - and does not
    -addresses construction of a new P2C commitments or transactions containing them
    +address construction of new P2C commitments or transactions containing them
     in their outputs.<ref>'''Why only spending of P2C tweaked outputs is covered'''
    -P2C tweaks commit to external data, some of which may represent certain value
    +P2C tweaks commit to external data, some of which may represent certain values
     (like in some sidechains, single-use-seal applications like RGB etc). Creation
    -of such outputs much allow hardware devices to understand the structure of such
    +of such outputs allows hardware devices to understand the structure of such
     extra-transaction data, which may be in different formats and constantly
    -involve. Thus, this should be addresses with a separate standards (or be a
    +involve. Thus, this should be addresses with a separate standard (or be
     vendor-based). The current proposal only touches the question of spending an
    -output which contained previously created P2C commitment, which does not creates
    -a new commitment and does not provides that kind of risk of extra-blockchain
    -value loses.</ref>
    +output that contained previously created P2C commitments, which does not create
    +a new commitment and does not provide that kind of risk of extra-blockchain
    +value losses.</ref>
    

    jonatack commented at 4:48 PM on January 6, 2025:

    Pulled a version of this into #1740.

  6. in bip-0384.mediawiki:74 in 50f06e9604
      70 | @@ -71,7 +71,7 @@ Invalid descriptors
      71 |  ==Backwards Compatibility==
      72 |  
      73 |  <tt>combo()</tt> descriptors use the format and general operation specified in [[bip-0380.mediawiki|380]].
      74 | -As this is a wholly new descriptor, it is not compatible with any implementation.
      75 | +As this is a wholly new descriptor, it is not compatible with any implementations.
    


    jonatack commented at 1:31 PM on December 17, 2024:

    I think this is fine in the singular form.

  7. jonatack commented at 1:31 PM on December 17, 2024: member

    A few comments.

  8. jonatack renamed this:
    Fix
    Minor spelling/grammar fixups in BIPs 372 and 381
    on Dec 17, 2024
  9. jonatack commented at 4:46 PM on January 6, 2025: member

    There has been no update here since the PR was opened. I've pruned, squashed and cherry-picked the commits here into #1740 to close this.

  10. jonatack closed this on Jan 6, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-28 15:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me