BIP372, BIP381: editorial fixups #1740

pull jonatack wants to merge 2 commits into bitcoin:master from jonatack:2025-01-merge-misc-fixups changing 2 files +33 −33

jonatack commented at 4:44 PM on January 6, 2025: member

Merges and improves on the editorial spelling/grammar suggestions in #1720.

Closes #1720.
BIP372, BIP381: trivial spelling fixups 450cdbbdaf
BIP372: editorial grammar fixups e36714eefa
jonatack merged this on Jan 6, 2025
jonatack closed this on Jan 6, 2025
jonatack deleted the branch on Jan 6, 2025
in bip-0372.mediawiki:122 in e36714eefa
```
 121 | -P2C tweaks commit to external data, some of which may represent certain value
 122 | -(like in some sidechains, single-use-seal applications like RGB etc). Creation
 123 | -of such outputs much allow hardware devices to understand the structure of such
 124 | +P2C tweaks commit to external data, some of which may represent certain values
 125 | +(like in some sidechains, single-use-seal applications like RGB, etc). Creation
 126 | +of such outputs may allow hardware devices to understand the structure of such
```
theuni commented at 5:16 PM on January 6, 2025:

This is a bit clunky before and after. I suspect "much allow" was supposed to be "must allow", which would be more readable as "would require".

jonatack commented at 6:30 PM on January 6, 2025:

Thanks for taking a look. @dr-orlovsky what is your intended meaning here?

dr-orlovsky commented at 1:12 PM on January 7, 2025:

Yes, it was "must allow" typo. "May allow" is more correct. "Would require" has an opposite meaning

theuni commented at 9:10 PM on January 7, 2025:

Happy to be wrong, thanks for chiming in!
theuni commented at 5:21 PM on January 6, 2025: member

Considering this isn't just 1:1 spell-check fixes, it was merged a bit too quickly imo :(

LGTM other than the comment. Considering the weight of the words "may", "must", etc, in BIPS, it would be nice to have another set of eyes on changes like this before merging.
jonatack commented at 12:05 AM on January 7, 2025: member

@theuni that's fair, thank you for the feedback, wouldn't have hurt to wait a bit.
Scutua approved
Scutua approved
Scutua approved

Contributors

Linked (view graph)

#1720 Minor spelling/grammar fixups in BIPs 372 and 381