Update BIP-352 status to Final #1737

1. 
   Gudnessuche commented at 1:32 pm on January 3, 2025: contributor

   Changed the status of BIP-352 from Proposed to Final to reflect its acceptance and finalization. This update marks the completion of the review process and the formal acceptance of the proposal.
2. Update BIP-352 status to Final

   Changed the status of BIP-352 from Proposed to Final to reflect its acceptance and finalization. This update marks the completion of the review process and the formal acceptance of the proposal.

   4a91185441
3. 
   jonatack commented at 3:47 pm on January 3, 2025: member

   It might be a little early: the current status commit was in 9929215dcf47235bc8a54b8549c2f32f2987463c, this BIP was merged less than a year ago in #1458, and further updates may be found as developers implement it more widely. Please provide justification in the pull description for this proposed update based on the criteria enumerated in BIP 2, Section Progression to Final status.
4. jonatack added the label Proposed BIP modification on Jan 3, 2025
5. in bip-0352.mediawiki:8 in 4a91185441

   4@@ -5,7 +5,7 @@
   5   Author: josibake <josibake@protonmail.com>
   6           Ruben Somsen <rsomsen@gmail.com>
   7   Comments-URI: https://github.com/bitcoin/bips/wiki/Comments:BIP-0352
   8-  Status: Proposed
   9+  Status: Final
   

   ---

   ---

   

   jonatack commented at 3:55 pm on January 3, 2025:

   If this change moves forward, the README would need to be updated as well (in the same commit, and in this pull, not a new one)
6. bitcoin deleted a comment on Jan 3, 2025
7. bitcoin deleted a comment on Jan 3, 2025
8. jonatack marked this as a draft on Jan 6, 2025
9. 
   jonatack commented at 4:49 pm on January 10, 2025: member

   Closing for now for the reasons in #1737 (comment). Happy to re-open at your request if you address the feedback.
10. jonatack closed this on Jan 10, 2025

    ---

11. jonatack added the label PR Author action required on Jan 10, 2025
12. 
    murchandamus commented at 7:40 pm on January 13, 2025: contributor

    Just for the record, after taking a look here, I agree with @jonatack. BIP 352 doesn’t seem widely adopted yet, afaia there is only a single implementation, and especially the implementation the BIP’s authors are contributing to is still in progress, so moving it to final seems premature.
13. 
    Gudnessuche commented at 7:58 pm on January 13, 2025: contributor

    I agree. For me, I just felt, given the DLEQ BIP, got drafted, this BIP seemed sufficient.

    I know Josie awaits an upstream PR merge to secp’s library to handle all the cryptography heavy lifting, I just felt enough people who got the gist had already started shipping to production. e.g CakeWallet, DanaWallet, SeedSigner, Bitbox02.

    The cryptography Josie and Ruben put out is sound!!!!!!!!

14. 
    murchandamus commented at 8:16 pm on January 13, 2025: contributor

    DanaWallet’s readme describes it as experimental, SeedSigner Silent Payment support seems to be an experiment Keith posted about on Twitter, but there are still open issues for it, and Bitbox only has sending support. While there definitely is some excitement and work is in progress, only CakeWallet has full support. :shrug:
15. 
    Gudnessuche commented at 1:54 pm on January 15, 2025: contributor

    Add wasabi to that list. they just added send supports. Also, we missed blue wallet as well

Contributors
Gudnessuche jonatack murchandamus

Labels
Proposed BIP modification PR Author action required