I noticed an issue in the __truediv__ method of the FE class where the division was being performed incorrectly. The method was returning FE(self, a), which doesn’t account for the numerator and denominator fields (_num and _den).
To fix this, I’ve updated the code to return FE(self._num, self._den * a), which properly creates a new FE object with the same numerator and the denominator multiplied by the given argument a.
cc: @andrewtoth
don't think there's a problem since the initialiser method has support for both FE and int. see code comments in the __init__ method.
this line - https://github.com/bitcoin/bips/blob/6d2f0d64fc226661bd8dced658aca8c575fb42e1/bip-0374/secp256k1.py#L34-L36 sets the numerator and denominator (_num and _den) with self's numerator and denominator.
so we don't need to pass them separately to the initialiser method.
This file was mostly taken from https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/crypto/secp256k1.py#L79-L81, so should likely be fixed upstream if it's a problem.
Seems best to close here unless the reference implementation in libsecp changes or is incorrect, @brawncode what do you think?
@brawncode feel free to comment here if there is a reason to re-open this.