BIP379: add missing hexadecimal notations #1778

1. 
   sky-coderay commented at 3:35 pm on February 28, 2025: contributor

   Replace SIZE <20> EQUALVERIFY with SIZE 32 EQUALVERIFY for sha256(h), hash256(h), ripemd160(h), and hash160(h).
   sha256/hash256 produce 32 bytes, not 20, so the original size check is incorrect.
2. Update bip-0379.md 6312ae3e24
3. 
   jonatack commented at 3:49 pm on February 28, 2025: member

   20 in hexadecimal is decimal 32; seems fine as-is?
4. 
   sky-coderay commented at 3:55 pm on February 28, 2025: contributor

   it’s actually decimal 20, not 0x20 the document incorrectly checks for 20 bytes instead of 32 bytes
5. jonatack requested review from achow101 on Feb 28, 2025
6. 
   jonatack commented at 5:09 pm on February 28, 2025: member

   Just asked one of the BIP authors, and they suggest instead replacing <20> with <0x20>. Mind updating?
7. jonatack removed review request from achow101 on Feb 28, 2025
8. jonatack added the label Proposed BIP modification on Feb 28, 2025
9. jonatack added the label Pending acceptance on Feb 28, 2025
10. Update bip-0379.md 091824b3bb
11. 
    sky-coderay commented at 6:53 pm on February 28, 2025: contributor

    done ! thanks
12. jonatack renamed this:
    fix incorrect size checks for 32-byte hashes
    BIP379: add missing hexadecimal notations
    on Mar 1, 2025
13. jonatack requested review from achow101 on Mar 1, 2025
14. 
    murchandamus commented at 3:02 pm on March 12, 2025: contributor

    ACK 091824b3bbba90e639c1b193173b8bb049c48daf
15. murchandamus approved
16. 
    murchandamus commented at 4:29 pm on March 21, 2025: contributor

    I’m merging this, as this matches the BIP Author’s preference to be from prior conversation. @achow101: Post-merge ACK appreciated, or please let us know if you changed your mind.
17. murchandamus merged this on Mar 21, 2025
18. murchandamus closed this on Mar 21, 2025

    ---

Contributors
sky-coderay jonatack murchandamus

Review Requested
achow101

Labels
Proposed BIP modification Pending acceptance