Replace SIZE <20> EQUALVERIFY with SIZE 32 EQUALVERIFY for sha256(h), hash256(h), ripemd160(h), and hash160(h).
sha256/hash256 produce 32 bytes, not 20, so the original size check is incorrect.
BIP379: add missing hexadecimal notations #1778
pull sky-coderay wants to merge 2 commits into bitcoin:master from sky-coderay:patch-1 changing 1 files +4 −4-
sky-coderay commented at 3:35 PM on February 28, 2025: contributor
-
Update bip-0379.md 6312ae3e24
-
jonatack commented at 3:49 PM on February 28, 2025: member
20 in hexadecimal is decimal 32; seems fine as-is?
-
sky-coderay commented at 3:55 PM on February 28, 2025: contributor
it's actually decimal 20, not 0x20 the document incorrectly checks for 20 bytes instead of 32 bytes
- jonatack requested review from achow101 on Feb 28, 2025
-
jonatack commented at 5:09 PM on February 28, 2025: member
Just asked one of the BIP authors, and they suggest instead replacing <20> with <0x20>. Mind updating?
- jonatack removed review request from achow101 on Feb 28, 2025
- jonatack added the label Proposed BIP modification on Feb 28, 2025
- jonatack added the label Pending acceptance on Feb 28, 2025
-
Update bip-0379.md 091824b3bb
-
sky-coderay commented at 6:53 PM on February 28, 2025: contributor
done ! thanks
- jonatack renamed this:
fix incorrect size checks for 32-byte hashes
BIP379: add missing hexadecimal notations
on Mar 1, 2025 - jonatack requested review from achow101 on Mar 1, 2025
-
murchandamus commented at 3:02 PM on March 12, 2025: contributor
ACK 091824b3bbba90e639c1b193173b8bb049c48daf
- murchandamus approved
-
murchandamus commented at 4:29 PM on March 21, 2025: contributor
I’m merging this, as this matches the BIP Author’s preference to be from prior conversation. @achow101: Post-merge ACK appreciated, or please let us know if you changed your mind.
- murchandamus merged this on Mar 21, 2025
- murchandamus closed this on Mar 21, 2025
