BIP 345: Fix OP_VAULT_RECOVER specification for the recovery-sPK-hash #1797

1. 
   shesek commented at 10:24 pm on March 22, 2025: contributor

   The recovery scriptPubKey needs to be prefixed with its CompactSize-encoded length when computing the sPK hash.

   I verified this by:

   • Checking the functional tests, where recovery_spk_tagged_hash() is implemented using ser_string() which adds the CompactSize-encoded length prefix
   • Using an implementation in Minsc to construct a transaction spending using OP_VAULT_RECOVER and broadcasting it to mutinynet (see line 2 for the recovery sPK hash computation)
   • Checking with @jamesob

   Alternatively, the implementation could be amended to match the current specification and drop the length prefix. Since this is committing to a single element, the length isn’t really necessary.

2. BIP 345: Fix OP_VAULT_RECOVER specification for the recovery-sPK-hash

   The recovery scriptPubKey needs to be prefixed with its CompactSize-encoded length.

   f23e3c7318
3. jonatack added the label Proposed BIP modification on Mar 23, 2025
4. jonatack added the label Pending acceptance on Mar 23, 2025
5. 
   jonatack commented at 6:53 pm on March 24, 2025: member

   cc @jamesob for feedback

Contributors
shesek jonatack

Labels
Proposed BIP modification Pending acceptance