BIP 345: Fix OP_VAULT_RECOVER specification for the recovery-sPK-hash #1797

pull shesek wants to merge 1 commits into bitcoin:master from shesek:patch-3 changing 1 files +2 −1

shesek commented at 10:24 pm on March 22, 2025: contributor
The recovery scriptPubKey needs to be prefixed with its CompactSize-encoded length when computing the sPK hash.

I verified this by:
- Checking the functional tests, where recovery_spk_tagged_hash() is implemented using ser_string() which adds the CompactSize-encoded length prefix
- Using an implementation in Minsc to construct a transaction spending using OP_VAULT_RECOVER and broadcasting it to mutinynet (see line 2 for the recovery sPK hash computation)
- Checking with @jamesob
Alternatively, the implementation could be amended to match the current specification and drop the length prefix. Since this is committing to a single element, the length isn’t really necessary.

BIP 345: Fix OP_VAULT_RECOVER specification for the recovery-sPK-hash

The recovery scriptPubKey needs to be prefixed with its CompactSize-encoded length.

f23e3c7318

jonatack added the label Proposed BIP modification on Mar 23, 2025
jonatack added the label Pending acceptance on Mar 23, 2025
jonatack commented at 6:53 pm on March 24, 2025: member

cc @jamesob for feedback
bitcoin deleted a comment on Apr 9, 2025
murchandamus commented at 10:13 pm on June 20, 2025: contributor

Given that BIP 345 was withdrawn: @jamesob and @shesek, Is this pull request still relevant or should it be closed?
murchandamus added the label PR Author action required on Jul 16, 2025
jamesob commented at 6:27 pm on August 8, 2025: contributor

Looks good to me - doesn’t hurt to keep updated.
jonatack removed the label Pending acceptance on Aug 8, 2025
jonatack removed the label PR Author action required on Aug 8, 2025
jonatack merged this on Aug 8, 2025
jonatack closed this on Aug 8, 2025
jonatack commented at 8:12 pm on August 8, 2025: member

ACK, as this modifies the specification, it might be worth adding a changelog.