bip340: Change license of code and test vectors #1807

pull real-or-random wants to merge 1 commits into bitcoin:master from real-or-random:340-code-license-change changing 2 files +19 −1
  1. real-or-random commented at 8:42 am on April 1, 2025: contributor

    See https://github.com/bitcoin/bips/commits/master/bip-0340 for a list of contributors. I have obtained permission to do this change from all contributors in private. Nevertheless, it would be good to get an ACK from every contributor in order to have publicly available evidence.

    I haven’t contacted @Sajjon and @satsie, whose contributions constitute of fixing not more than two typos and are thus below the threshold of originality required for copyright to be applicable.

  2. Sajjon commented at 8:43 am on April 1, 2025: contributor
  3. jonasnick commented at 8:45 am on April 1, 2025: contributor
    ACK
  4. theStack approved
  5. theStack commented at 12:16 pm on April 1, 2025: contributor
    ACK e77399e57ceb2696e66734c1352cdfb65dd2fe5d
  6. ysangkok commented at 12:49 pm on April 1, 2025: contributor
    ACK e77399e57ceb2696e66734c1352cdfb65dd2fe5d
  7. jonatack added the label Proposed BIP modification on Apr 1, 2025
  8. in bip-0340.mediawiki:12 in e77399e57c outdated
     8@@ -9,6 +9,7 @@
     9   Status: Final
    10   Type: Standards Track
    11   License: BSD-2-Clause
    12+  License-Code: BSD-2-Clause OR MIT OR CC0-1.0
    


    jonatack commented at 3:09 pm on April 1, 2025:

    Nit, per BIP3 (proposed, so this could be done later, unless it also would fix the CI):

    If there are multiple acceptable licenses, each should be on a separate line...the license list is an "OR choice", not an "AND also" requirement.

    0License-Code: BSD-2-Clause
    1              MIT
    2              CC0-1.0
    

    murchandamus commented at 6:52 pm on April 1, 2025:
    The rules for licenses are the same per BIP2 or BIP3: if multiple licenses are provided fulfilling the terms of any license is sufficient, and the formatting is required to be as @jonatack suggests.

    real-or-random commented at 7:00 am on April 2, 2025:
    Ok, but then I suggest that the BIP3 draft is changed to use SPDX License Expressions instead. These can involve OR and this is much clearer than just listing them: It’s a widely used standard, and anyone reading it will understand it without the need to read BIP3. It should be easy enough to change the existing BIPs.
  9. in bip-0340.mediawiki:289 in e77399e57c outdated
    284@@ -284,7 +285,8 @@ Blind Schnorr signatures could for example be used in [https://github.com/Elemen
    285 
    286 == Test Vectors and Reference Code ==
    287 
    288-For development and testing purposes, we provide a [[bip-0340/test-vectors.csv|collection of test vectors in CSV format]] and a naive, highly inefficient, and non-constant time [[bip-0340/reference.py|pure Python 3.7 reference implementation of the signing and verification algorithm]].
    289+For development and testing purposes, we provide a [[bip-0340/test-vectors.csv|collection of test vectors in CSV format]] and a naive, highly inefficient, and non-constant time [[bip-0340/reference.py|pure Python 3.7 reference implementation of the signing and verification algorithm]],
    290+both licensed under either the BSD-2-Clause License, the MIT License, or CC0 1.0, at your choice.
    


    murchandamus commented at 6:53 pm on April 1, 2025:

    “either … or” is only ever used with two options. May I suggest:

    0both licensed under one of the BSD-2-Clause License, the MIT License, or CC0 1.0, at your choice.
    

    real-or-random commented at 6:53 am on April 2, 2025:

    “either … or” is only ever used with two options.

    That’s obviously wrong. My usage is a counterexample.

    On a more serious note, even experts disagree on this matter, see https://en.wiktionary.org/wiki/either#cite_note-Pullum-2024-2 and https://english.stackexchange.com/questions/170409/whats-the-best-way-to-use-either-on-more-than-two-options?noredirect=1&lq=1#comment354637_170409 … But yeah, let me make that change.


    real-or-random commented at 7:22 am on April 2, 2025:
    Just dropped the “either” because “at your choice” should be clear enough.

    murchandamus commented at 3:58 pm on April 2, 2025:

    Fair enough, it sounded wrong to me and my native speaker colleagues collectively confirmed my stance, but of course only a Sith deals in absolutes.

    image

  10. in bip-0340/LICENSE:3 in e77399e57c outdated
    0@@ -0,0 +1,11 @@
    1+BSD-2-Clause OR MIT OR CC0-1.0
    2+
    3+The contents of this directory are provided under either of the following terms,
    


    murchandamus commented at 6:54 pm on April 1, 2025:
    0The contents of this directory are provided under any of the following terms,
    

    real-or-random commented at 7:22 am on April 2, 2025:
    rephrased
  11. murchandamus commented at 6:54 pm on April 1, 2025: contributor
    This seems like something that might be mentioned in the changelog?
  12. real-or-random force-pushed on Apr 2, 2025
  13. real-or-random force-pushed on Apr 2, 2025
  14. ysangkok commented at 1:34 pm on April 2, 2025: contributor
    ACK b8d11eb
  15. bip340: Change license of code and test vectors
    See https://github.com/bitcoin/bips/commits/master/bip-0340 for a list
    of contributors. I have obtained permission to do this change from all
    contributors in private. Nevertheless, it would be good to get an ACK
    from every contributor in order to have publicly available evidence.
    
     - [ ] @sipa
     - [ ] @jonasnick
     - [ ] @theStack
     - [ ] @ysangkok
    
    I haven't contacted @Sajjon and @satsie, whose contributions constitute
    of fixing not more than two typos and are thus below the threshold of
    originality required for copyright to be applicable.
    84a64ec1c6
  16. real-or-random force-pushed on Apr 2, 2025
  17. real-or-random commented at 1:39 pm on April 2, 2025: contributor
    Force-pushed to fix another typo, sorry
  18. ysangkok commented at 1:41 pm on April 2, 2025: contributor
    ACK 84a64ec
  19. sipa commented at 1:46 pm on April 2, 2025: member
    ACK 84a64ec1c6f39e3dd4ddc98a60a772340dd0c2ac
  20. jonatack commented at 2:45 pm on April 2, 2025: member
    ACK
  21. jonatack merged this on Apr 2, 2025
  22. jonatack closed this on Apr 2, 2025

  23. in bip-0340.mediawiki:292 in 84a64ec1c6
    286@@ -284,7 +287,10 @@ Blind Schnorr signatures could for example be used in [https://github.com/Elemen
    287 
    288 == Test Vectors and Reference Code ==
    289 
    290-For development and testing purposes, we provide a [[bip-0340/test-vectors.csv|collection of test vectors in CSV format]] and a naive, highly inefficient, and non-constant time [[bip-0340/reference.py|pure Python 3.7 reference implementation of the signing and verification algorithm]].
    291+For development and testing purposes, we provide a [[bip-0340/test-vectors.csv|collection of test vectors in CSV format]],
    292+a naive, highly inefficient, and non-constant time [[bip-0340/reference.py|pure Python 3.7 reference implementation of the signing and verification algorithm]]
    293+as well as the [[bip340/test-vectors.py|script used to generate the test vectors]]
    


    jonatack commented at 2:49 pm on April 2, 2025:
    0as well as the [[bip-0340/test-vectors.py|script used to generate the test vectors]]
    

    jonatack commented at 3:50 pm on April 2, 2025:
  24. jonatack commented at 2:50 pm on April 2, 2025: member
    One URL to fix up.

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-04-19 01:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me