BIP127: Replace network_magic with BIP44 coin_type in ProofOfReserves message #1834

pull GarmashAlex wants to merge 1 commits into bitcoin:master from GarmashAlex:hpp1 changing 1 files +4 −5

GarmashAlex commented at 6:08 PM on April 24, 2025: contributor
This commit updates the ProofOfReserves message in the Protocol Buffers specification to use BIP44 coin type IDs from SLIP-0044 instead of network magic values.

The changes include:
- Renaming the field from 'network_magic' to 'coin_type'
- Updating the comments to reference the SLIP-0044 registry
- Adding examples for Bitcoin mainnet (0x80000000) and Testnet (0x80000001)
Replace network_magic with BIP44 coin_type in ProofOfReserves message 756f4cdde7
murchandamus renamed this:
~~Replace network_magic with BIP44 coin_type in ProofOfReserves message~~
BIP127: Replace network_magic with BIP44 coin_type in ProofOfReserves message
on Apr 24, 2025
murchandamus added the label Proposed BIP modification on Apr 24, 2025
murchandamus added the label Pending acceptance on Apr 24, 2025
murchandamus commented at 6:22 PM on April 24, 2025: member

Pinging the author: @stevenroose
jonatack commented at 2:26 AM on June 20, 2025: member

@stevenroose mind weighing in here, as BIP author?
murchandamus commented at 12:59 AM on February 28, 2026: member

@stevenroose: If you have a minute, could you take a look at this?
jonatack commented at 1:55 AM on April 25, 2026: member

This PR was opened one year ago today.

Friendly nudge to BIP author https://github.com/stevenroose if you can have a look here.

Contributors

Labels