The pseudocode in bip-0119 used stack[-1] while the rest of execute_bip_119 consistently accessed the interpreter stack via self.stack.
BIP-119: use self.stack[-1] in execute_bip_119 #2043
pull phrwlk wants to merge 1 commits into bitcoin:master from phrwlk:fix/bip-0119-pseudocode-stack-access changing 1 files +1 −1-
phrwlk commented at 3:59 PM on November 24, 2025: contributor
-
BIP-119: use self.stack[-1] in execute_bip_119 81c6b39375
- jonatack added the label Typo-to-be-collected on Nov 24, 2025
-
jonatack commented at 7:12 PM on November 24, 2025: member
LGTM, labeled as
typo-to-be-collectedfor the end-of-month typos batch. - murchandamus removed the label Typo-to-be-collected on May 23, 2026
- murchandamus added the label Fixups on May 23, 2026
- murchandamus approved
-
murchandamus commented at 12:22 AM on May 23, 2026: member
Trivial change that looks right. It seems that the typo collection is no longer the modus operandi, so I’ll just merge this now instead of someone looking at it again in a month or two.
- murchandamus merged this on May 23, 2026
- murchandamus closed this on May 23, 2026
Contributors
Labels