fix: correct misleading ORDER_HALF comment in bip-0374 #2059

pull zeroprooff wants to merge 1 commits into bitcoin:master from zeroprooff:fix-secp256k1-order-half-comment changing 1 files +2 −2
  1. zeroprooff commented at 5:45 AM on December 16, 2025: contributor

    The comment for ORDER_HALF incorrectly stated it represents "Number of valid distinct x coordinates on the curve". This is wrong - ORDER_HALF is simply half the group order, commonly used for ECDSA low-S signature normalization. The number of valid x coordinates on secp256k1 is approximately (p-1)/2 where p is the field size, which is a completely different value.

    Also clarified the ORDER comment from "plus 1 for infinity" to "including infinity" for better accuracy.

  2. fix: correct misleading ORDER_HALF comment in bip-0374 ec54ef8e95
  3. murchandamus added the label Typo-to-be-collected on Feb 27, 2026
  4. murchandamus added the label Pending acceptance on Feb 27, 2026
  5. jonatack commented at 8:30 PM on April 20, 2026: member

    Hi @zeroprooff thank you, this looks like an accurate improvement to the code comments, but the code itself has changed and has also been moved. Will look into rebasing and, if still relevant, cherry-picking your commit into a batched cleanup PR (the commit will remain credited to you).

  6. jonatack closed this on Apr 20, 2026


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 12:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me