BIP-0322: polishing follow-up #2155

pull guggero wants to merge 4 commits into bitcoin:master from guggero:bip-0322-follow-up changing 2 files +51 −49
  1. guggero commented at 7:24 AM on May 8, 2026: contributor

    Addresses a couple of review comments in #2141 as a follow-up.

  2. guggero force-pushed on May 8, 2026
  3. in bip-0322.mediawiki:37 in d9feef36b5
      33 | @@ -33,7 +34,8 @@ interoperability with existing signing hardware, we also define a signature mess
      34 |  resembles a Bitcoin transaction (except that it contains an invalid input, so it cannot be spent on
      35 |  any real network).
      36 |  
      37 | -The Proof of Funds variant allows demonstrating control of a set of UTXOs.
      38 | +The [[bip-0322.mediawiki#full-proof-of-funds|Proof of Funds]] variant allows demonstrating control
    


    jonatack commented at 6:40 PM on May 8, 2026:

    Do you think an anchor link would be best here?

    See just-merged https://github.com/bitcoin/bips/pull/2091/changes for the format.

  4. jonatack added the label BIP Update by Owner on May 8, 2026
  5. in bip-0322.mediawiki:264 in d9feef36b5


    jonatack commented at 7:07 PM on May 8, 2026:

    Let ''T'' be

    Highlighting this typo separately.

  6. jonatack commented at 7:22 PM on May 8, 2026: member

    Thanks for following up @guggero!

    Here are some suggested edits. Feel free to pick and choose (or for the BIP names, adopt a different format to be used consistently):

    https://github.com/jonatack/bips/commits/2026-05-bip322-suggested-edits-or-areas-of-feedback/

  7. BIP-0322: change role to author, add required BIPs dd0cb53afa
  8. BIP-0322: link to later sections for clarity 3b251b7fd2
  9. BIP-0322: clarify sighash flag for P2TR 8f18f02f15
  10. BIP-0322: grammar and readability touchup
    Co-authored-by: Jon Atack <jon@atack.com>
    6a61279d6c
  11. guggero force-pushed on May 9, 2026
  12. guggero commented at 3:56 PM on May 9, 2026: contributor

    Thanks a lot for the review and suggested fixes, @jonatack! Took almost all of them, really appreciate the inputs.

    I also added a commit to clarify the use of the SIGHASH_DEFAULT for Taproot-based inputs.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bips. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-05-09 19:10 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me